Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

Hi On Wed, Aug 19, 2020 at 10:20 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave/Team, > > As per discussion with the UX team, Few updates on style-guide patch. > 1. I have missed removing the "proposed" keyword from the "High-Contract" > theme name. > Right. > 2. I have no

pgAdmin 4 commit: Improve code coverage and API test cases for Grant Wi

Improve code coverage and API test cases for Grant Wizard. Fixes #5344 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64152947828942e934217504da5ec8a70c551a6b Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_4_26.

pgAdmin 4 commit: Added SQL Formatter support in Query Tool. Fixes #204

Added SQL Formatter support in Query Tool. Fixes #2042 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e6480513b4966ec647f1d96ff2bfe3d8c8e966 Author: Dave Page Modified Files -- docs/en_US/images/preferences_sql_formatting.png

Re: WIP: SQL Formatter

Thanks, patch applied. On Tue, Aug 18, 2020 at 3:53 PM Dave Page wrote: > Hi > > On Tue, Aug 18, 2020 at 7:33 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> The patch looks good to me except pep8 issues. >> > > Thanks, fixed. > > >> In the below SQL - BEGIN

Re: [pgAdmin][RM5344][Code Coverage] Improve API test cases for Grant Wizard

Thanks, patch applied. On Wed, Aug 19, 2020 at 1:16 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have added test cases for Grant wizard as per RM-5344 > > > PFA patch for the same. > > > > Regards, > Nikhil Mohite. > --

pgAdmin 4 commit: Cleanup a bunch of duplicated gettext calls.

Cleanup a bunch of duplicated gettext calls. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99a7ada58a495d4503a91b1b1d6cab3fc2ec69ca Modified Files -- .../sqleditor/utils/query_tool_preferences.py | 182 -

Re: pgAdmin4 v4.25 candidate builds

@Akshay Joshi One round of testing has been completed, Can you please release pgadmin4 4.25? Kind regards, On Tue, Aug 18, 2020 at 6:25 PM Akshay Joshi wrote: > Hi All > > We have found an issue due to the release of a new version of *"bcrypt" > *v3.2.0, > which is having some issue on Window

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

Hi Akshay, Please find the updated patch attached in this email. On Wed, Aug 19, 2020 at 2:40 PM Akshay Joshi wrote: > Hi Rahul > > I have committed Khushboo's patch where she has introduced a new method > 'not_found_error_msg', so instead of creating a new constant > 'TABLE_NOT_FOUND_MSG' use

pgAdmin 4 v4.25 released

The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.25. This release of pgAdmin 4 includes 30 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/4.25/release_notes_4_25.html. pgAdmin is the leading Open Sourc

pgAdmin 4 commit: Tag REL-4_25 has been created.

Tag REL-4_25 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_25 Log Message --- Tag v4.25

pgAdmin 4 commit: Fixed code smell 'Define a constant instead of duplic

Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f3e8596e3ce811ab5665e615411992ba9632f03 Author: Rahul Shirsat Modified Files -- web/

pgAdmin 4 commit: Fixed code smell 'Define a constant instead of duplic

Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbbbc362212c6d8b1ad1f670182d9b2fcc67f3e2 Modified Files -- web/pgadmin/about/__init__.

pgAdmin 4 commit: Define constants for preferences label to fix SonarQu

Define constants for preferences label to fix SonarQube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=103b08c9c567f29b6fcd897e0725aa1095d38906 Modified Files -- web/pgadmin/browser/__init__.py| 10 +-

[pgAdmin][SonarQube]: Cognitive complexity

Hi Hackers, The attached patch will reduce cognitive complexity for the following functions. 1. web/.../databases/schemas/domains/__init__.py - 16 to 15. 2. web/.../tables/row_security_policies/__init__.py - 17 to 15. 3. web/pgadmin/tools/debugger/__init__.py - 23 to 15 4. user_mappin

Re: [pgAdmin][SonarQube]: Cognitive complexity

Please ignore the previous patch, find the updated patch in this mail. On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > The attached patch will reduce cognitive complexity for the following > functions. > >1. web/.../databases/schemas/

Re: [pgAdmin][SonarQube]: Cognitive complexity

Hi Pradip Following are the review comments: - Change the function name to "_get_supported_browser" instead of "_get_browser_supported". - Added docstring to the functions in below format: """ :param trans_id: :param session_obj: :param diff_model_obj: :return: """ - Can we make

Patch for SonarQube code scan fixes.

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Foreign servers: - Refactor this function to reduce its Cognitive Complexity from 49 to the 15 allowed. 2. bgprocess/process: - Refactor this function to reduce its Cognitive Complexit