pgAdmin 4 commit: Fixed an issue where debugger doesn't work if the sea

2020-08-12 Thread Akshay Joshi
Fixed an issue where debugger doesn't work if the search path is set other than 'public'. Fixes #4123 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dd313f5fc8e7422759f85de84b7955f43715914 Author: Aditya Toshniwal Modified Files --

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

2020-08-12 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix certain errors occurring when saving preferences. This is the regression of patch committed. Please review. On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal < > aditya.tosh

pgAdmin 4 commit: Resolve schema diff dependencies by selecting the app

2020-08-12 Thread Akshay Joshi
Resolve schema diff dependencies by selecting the appropriate node automatically and maintain the order in the generated script. Fixes #5730 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b688cf949ee96e6552253bd4607e5f37d4d839c Author: Khush

pgAdmin 4 commit: Fixed errors occurring when saving preferences, regre

2020-08-12 Thread Akshay Joshi
Fixed errors occurring when saving preferences, regression of SonarQube fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=caeea7940adf5cc57b7634b3fab1b37ddf1f7b42 Author: Aditya Toshniwal Modified Files -- web/pgadmin/utils/p

pgAdmin 4 commit: Fix PEP8

2020-08-12 Thread Akshay Joshi
Fix PEP8 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=26506a9727add43d2462a4577ee885e9fe6145be Modified Files -- web/pgadmin/tools/schema_diff/__init__.py | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

2020-08-12 Thread Akshay Joshi
Thanks, patch applied. On Wed, Aug 12, 2020 at 4:03 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix certain errors occurring when saving > preferences. This is the regression of patch committed. > Please review. > > On Tue, Aug 11, 20

Re: str never has attribute decode in py3

2020-08-12 Thread Khushboo Vashi
The patch looks good to me. On Tue, Aug 11, 2020 at 9:42 PM Cyril Jouve wrote: > >

pgAdmin 4 commit: The 'str' object never has attribute decode in Python

2020-08-12 Thread Akshay Joshi
The 'str' object never has attribute decode in Python3, so remove the dead code. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36574b25b697a1ee61fd5342755d5db1efec7306 Author: Cyril Jouve Modified Files -- web/pgadmin/__init__.p

Re: str never has attribute decode in py3

2020-08-12 Thread Akshay Joshi
Thanks, patch applied. On Wed, Aug 12, 2020 at 6:06 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > The patch looks good to me. > > On Tue, Aug 11, 2020 at 9:42 PM Cyril Jouve wrote: > >> >> -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postg

[pgAdmin4][Patch] - SonarQube Issues - 14 (String literals should not be duplicated, Cognitive Complexity of functions should not be too high)

2020-08-12 Thread Yogesh Mahajan
Hello, Please find patch which fixes issues related to rule from feature test modules - 1.String literals should not be duplicated - 3 issues 2.Cognitive Complexity of functions should not be too high - 10 issues Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 S

pgAdmin 4 commit: Upgrade font awesome from v4 to v5. Fixes #5731

2020-08-12 Thread Akshay Joshi
Upgrade font awesome from v4 to v5. Fixes #5731 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93adf6884f031ff0e02c60736d9d4588732fdd07 Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_4_25.rst