pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli

Fixed code smell 'String literals should not be duplicated' reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48737e6a02f171e7554d9171253b1f7d82886b63 Author: Yogesh Mahajan  Modified Files -- .../feature_tes

pgAdmin 4 commit: Fixed an issue where the user is not able to insert t

Fixed an issue where the user is not able to insert the data if the table and columns name contains special characters. Fixes #4387 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3dfe03a2a6839e510137960bea69b684f4f4b9d Author: Yogesh Mahajan

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1122e06f48ad2740868a92bbcbd6c0a290909c04 Author: Nikhil Mohite  Modified Files -- .../databases/foreign_data_wrappers/__init_

Re: [pgAdmin4][Patch] - SonarQube Issues - 13 (String literals should not be duplicated)

Thanks, patch applied. On Wed, Aug 5, 2020 at 7:47 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patch which fixes 15 issues related to rule from feature test > modules - > 1.String literals should not be duplicated > > Thanks, > Yogesh Mahajan > QA - Team > En

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Wed, Aug 5, 2020 at 6:03 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Index Constraint: > >- Refactor this function to reduce its Cognitive Complexity from 31 to >the 15 a

Re: Bug #4387 - User can not insert any value on view data if table and column name contains *SELECT '<alert("XSS ");//<';*

Thanks, patch applied. On Wed, Aug 5, 2020 at 1:39 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find patch which fixes 2 issues reported in Bug #4387 > > 1.Incorrect Column name when column name is like *'SELECT > '

[pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server

Hi Hackers, Attached is the patch to fix the issue mentioned in the subject. Regarding hiding the color legend when the server is disconnected, I feel it's good to have the legend visible as it says it's a graph. Otherwise, a box with error is ambiguous. Plus, it's not going to change anyway even

pgAdmin debugger failure when search_path set

Hi Dave/Team, I've been working on an issue to make debugger work no matter what the search patch is set. I've managed to call the appropriate functions from pgAdmin using a schema qualified name with no issues. However, the internal calls in the function don't look schema qualified. For instance,

pgAdmin 4 commit: Fixed an issue where ajax call continues to fire even

Fixed an issue where ajax call continues to fire even after disconnect the database server. Fixes #5716 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e494b1520d42c48d2a675b10b7a4eefe8d816b76 Author: Aditya Toshniwal Modified Files

Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server

Thanks, patch applied. On Thu, Aug 6, 2020 at 2:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue mentioned in the subject. > Regarding hiding the color legend when the server is disconnected, I feel > it's good to have the

pgAdmin 4 commit: Fixed ssh tunnel hang issue when the user tries to di

Fixed ssh tunnel hang issue when the user tries to disconnect the server. Fixes #4361 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aac0da4cbcd4af34f6f39d1954d911b725516ce5 Modified Files -- docs/en_US/release_notes_4_25.rst

pgAdmin 4 commit: Update the sshtunnel version to v0.1.5.

Update the sshtunnel version to v0.1.5. refs #4361 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48ec4085d2491e564a769cdbb623295af9fe3b33 Modified Files -- requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one

Hi Hackers, Attached is the followup patch to fix all the remaining issues (around 30) related to replacing the generic exception class with more specific ones. Please review. On Wed, Aug 5, 2020 at 12:42 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Aug 5, 2020 at 11:09 AM Aditya