Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-31 Thread Rahul Shirsat
Hi Akshay, A syntactical error in a jinja template caught yesterday in Yogesh's local setup of pgAdmin by running a test suite for the changes done in this RM. It's strange going through several testings, even on Jenkins, it passed but failed on Yogesh's machine. I have made changes for this issu

[pgAdmin 4 - Housekeeping #5327][Code Coverage] Improve API test cases for Schemas and Catalog Objects

2020-07-31 Thread Satish V
Hi Hackers, Please find the patch which improves the code coverage for Schema alone. Kindly create another RM for the Catalog Objects. Please review the patch. Thanks, Sathish V RM5327v1.patch Description: Binary data

Re: WIP: SQL Formatter

2020-07-31 Thread Dave Page
Hi Currently, all the CodeMirrors in pgAdmin use the settings from the Query > tool -> Editor, even though they're not related. I think you're right. > We should move all CodeMirror settings out of the Query tool and move it to > a new node - "SQL" may be. Editor and Auto-format would be sub node

Patch for SonarQube code scan fixes.

2020-07-31 Thread Nikhil Mohite
Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Utils Route: - Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 2. User Management: - Refactor this function to reduce its Cognitive Complexity fro