pgAdmin 4 commit: Remove old Python 2 compatibility code. Fixes #5700

2020-07-27 Thread Dave Page
Remove old Python 2 compatibility code. Fixes #5700 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f93cfe8c4cb94fffbc4d273f196a8f06e83c4bb8 Author: Cyril Jouve Modified Files -- docs/en_US/release_notes_4_25.rst

Re: Remove compat code for py<3.4

2020-07-27 Thread Dave Page
On Sun, Jul 26, 2020 at 5:29 PM Cyril Jouve wrote: > Hello, > > The attached patch removes compatibility code for python 2 and python <3.4. > Thanks, patch applied with one minor typo fix. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com

pgAdmin 4 commit: Add a --yes command line option to setup-web.sh to al

2020-07-27 Thread Dave Page
Add a --yes command line option to setup-web.sh to allow non-interactive use. Fixes #5610. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f57558fdb245153e210673489e838d03632cc2c4 Modified Files -- docs/en_US/release_notes_4_25.rs

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-07-27 Thread Akshay Joshi
Fixed following SonarQube issues:   1) Define a constant instead of duplicating this literal.   2) Reduce cognitive complexity (Patch by Aditya) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb0bc65cedcf00d5e539ae7e4eaad0786438fbb1 Modified

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

2020-07-27 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jul 27, 2020 at 11:00 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please ignore the previous patch. Attached is the latest. > > On Mon, Jul 27, 2020 at 10:42 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >>

Re: Runtime refactoring

2020-07-27 Thread Akshay Joshi
Hi Dave The patch is not applied, can you please rebase and send again. On Fri, Jul 17, 2020 at 3:40 PM Dave Page wrote: > BTW, this will fix https://redmine.postgresql.org/issues/5490 > > On Thu, Jul 16, 2020 at 10:41 AM Dave Page wrote: > >> Here's a pretty large patch that implements a majo

pgAdmin 4 commit: Fixed incorrect import statement for urlopen.

2020-07-27 Thread Akshay Joshi
Fixed incorrect import statement for urlopen. refs #5700 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed0dc62b690d805018b29bafb46bf438ac4a7d32 Modified Files -- web/pgadmin/browser/__init__.py | 2 +- 1 file changed, 1 insertion(

Re: Runtime refactoring

2020-07-27 Thread Dave Page
Hi Akshay, Updated patch attached. Thanks. On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi wrote: > Hi Dave > > The patch is not applied, can you please rebase and send again. > > On Fri, Jul 17, 2020 at 3:40 PM Dave Page wrote: > >> BTW, this will fix https://redmine.postgresql.org/issues/5490

[pgAdmin][SonarQube] Rule - variable shadows a builtin

2020-07-27 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to rename all the variables which shadows any python builtin. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" sonarqube.inbuilt.patch Descr