[pgAdmin][Patch] RM 5530 - Referenced Table is not displayed on foriegn key constraints property

Hi, Please find a patch fixing RM 5530. Refer Table Name is shown in Foreign Key creation dialogue & properties tab. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM5530_v1.patch Description: Binary data

pgAdmin 4 commit: Fix typo. Fixes #5517

Fix typo. Fixes #5517 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e0fa4a6cb2f50c1ecf2aa6c8411ac7e1faf4f196 Modified Files -- runtime/ConfigWindow.ui | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-)

[pgAdmin][RM5629] Properties tab of collection nodes should not allow editing

Hi Hackers, Attached is the patch to fix the issue where the user is able to edit properties when some of the collection nodes are selected (eg- tables, functions). The code is changed to make the columns non editable always. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker

Re: [pgAdmin][RM5629] Properties tab of collection nodes should not allow editing

Thanks, patch applied. On Thu, Jul 2, 2020 at 3:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue where the user is able to edit > properties when some of the collection nodes are selected (eg- tables, > functions). The cod

pgAdmin 4 commit: Fixed an issue where the user is able to edit propert

Fixed an issue where the user is able to edit properties when some of the collection nodes are selected. Fixes #5629 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ced296939f1231e5c1ef7bb48a2be45693609928 Author: Aditya Toshniwal Modified F

pgAdmin 4 commit: Added hints for 'Using' and 'With check' options of R

Added hints for 'Using' and 'With check' options of RLS Policy node. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b10315e2a83f388dea118b7ca99a342ad98f6c9 Author: Pradip Parkale Modified Files -- .../row_security_policies/stati

pgAdmin 4 commit: Comment out the 'yarn audit' command to fix the vulne

Comment out the 'yarn audit' command to fix the vulnerability found in the 'lodash' package. No fix is currently available. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec30e6ace78a813eb5215efc5c1f0e94582ffc12 Modified Files --

pgAdmin 4 commit: Ensure that the referenced table should be displayed

Ensure that the referenced table should be displayed on foreign key constraints. Fixes #5530 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1802f8a3f8f9d9369ed79ec88f36280fc9640af7 Author: Yogesh Mahajan Modified Files -- docs/e

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

Thanks, patch applied. On Thu, Jul 2, 2020 at 10:51 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch. I have added hints for 'Using' and 'With > check'. > > On Mon, Jun 22, 2020 at 5:45 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> w

Re: [pgAdmin][Patch] RM 5530 - Referenced Table is not displayed on foriegn key constraints property

Thanks, patch applied. On Thu, Jul 2, 2020 at 1:19 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch fixing RM 5530. > Refer Table Name is shown in Foreign Key creation dialogue & properties > tab. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Cor

[pgAdmin][patch] Dialog width issue

Hi Hackers, Attached is a tiny patch to fix the dialog sizes snapping to default widths. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" widthissue.patch Description: Binary data

Regression in of browser.js code

Hi, There was a regression where we have changed the panel variables in menu.py but we did not change their respective reference in JS which is causing issues while loading wcDocker Panel/Frames which are defined in python side. Ref: 830ac1cc9177c8b9ebed2304924cec1db22e45c3

Re: Regression in of browser.js code

On Thu, Jul 2, 2020 at 5:16 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > There was a regression where we have changed the panel variables in > menu.py but we did not change their respective reference in JS which is > causing issues while loading wcDocker Panel/Frames

Re: Regression in of browser.js code

Hi Khushboo, I am already on the latest code :) *commit* ec30e6ace78a813eb5215efc5c1f0e94582ffc12 (HEAD -> master, origin/master, origin/HEAD) -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Thu, Jul 2, 2020 at 5:25 PM Khushboo Vashi < khushboo.va...@ent

Re: Regression in of browser.js code

On Thu, Jul 2, 2020 at 5:33 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Khushboo, > > I am already on the latest code :) > Then your patch will not work. :) > > *commit* ec30e6ace78a813eb5215efc5c1f0e94582ffc12 (HEAD -> master, > origin/master, origin/HEAD) > > > -- > R

Re: Regression in of browser.js code

On Thu, Jul 2, 2020 at 5:41 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jul 2, 2020 at 5:33 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> I am already on the latest code :) >> > Then your patch will not work. :) > It is a

Re: Regression in of browser.js code

Ok the commit is reverted :( On Thu, Jul 2, 2020 at 5:45 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > > On Thu, Jul 2, 2020 at 5:41 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jul 2, 2020 at 5:33 PM Murtuza Zabuawala < >> murtuza.za

[pgAdmin][RM5287] Dark theme and other CSS related fixes

Hi Hackers, Attached is the patch to: 1) Change the way editable field is displayed in backgrid. 2) Change colors for alerts in dark theme. 3) Change the dashboard graph grid lines colors based on theme. 4) Fix the backgrid hover background issue. Fixes #5470. 5) Few other CSS improvements. Pleas

Re: [pgAdmin][RM4235]: Tab indent on a selection of lines is deleting content

Hi Team, I have removed duplicate code for codemirror settings. This will also resolve the issue with autocomplete is not working in the query tool due to earlier fixes. PFA patch Regards, Nikhil Mohite. On Wed, Jul 1, 2020 at 1:55 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, J

Re: [pgAdmin][RM4235]: Tab indent on a selection of lines is deleting content

Thanks, patch applied. On Fri, Jul 3, 2020 at 10:03 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have removed duplicate code for codemirror settings. > This will also resolve the issue with autocomplete is not working in the > query tool due to earlier fixes. > > PFA

pgAdmin 4 commit: Fixed issue where dialog sizes snapping to the defaul

Fixed issue where dialog sizes snapping to the default widths. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd4dc19add28d2533525fd102cfed62c73fe2f5e Author: Aditya Toshniwal Modified Files -- web/pgadmin/browser/static/js/node.

pgAdmin 4 commit: Fixed dark theme-related CSS and modify the color cod

Fixed dark theme-related CSS and modify the color codes. Fixes #5287 Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=341c3aded6edc

Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes

Thanks, patch applied. On Thu, Jul 2, 2020 at 5:54 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to: > 1) Change the way editable field is displayed in backgrid. > 2) Change colors for alerts in dark theme. > 3) Change the dashboard graph

pgAdmin 4 commit: Remove the duplicate code for tab indent and add the

Remove the duplicate code for tab indent and add the logic into codemirror. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ec8051303cb34f32c12a1762bef2d15c59cf22f Author: Nikhil Mohite Modified Files -- web/pgadmin/static/bundle

pgAdmin 4 commit: Fixed Cognitive Complexity code smell reproted by Son

Fixed Cognitive Complexity code smell reproted by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ab257d512afd5d7a5eca1d58ec5904c3aa531e7 Author: Nikhil Mohite Modified Files -- .../schemas/fts_configurations/__init__.

Re: [pgAdmin][patch] Dialog width issue

Thanks, patch applied. On Thu, Jul 2, 2020 at 4:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix the dialog sizes snapping to default > widths. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | S

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Wed, Jul 1, 2020 at 5:30 PM Ashesh Vashi wrote: > > > On Wed, Jul 1, 2020 at 5:28 PM Dave Page wrote: > >> >> >> On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> >>> On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite < >>> nikhil