pgAdmin 4 commit: Remove extra brackets from reverse engineering SQL of

2020-06-30 Thread Akshay Joshi
Remove extra brackets from reverse engineering SQL of RLS Policy. Fixes #5621 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46d26cd02910184be3de9f5ea238ff6a07c275e7 Modified Files -- docs/en_US/release_notes_4_24.rst

pgAdmin 4 commit: Remove extra brackets from reverse engineering SQL of

2020-06-30 Thread Akshay Joshi
Remove extra brackets from reverse engineering SQL of trigger. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88db5ec4d587a95c290fd8c1548047a01ce1205f Author: Zhang Jie Modified Files -- .../tables/templates/triggers/sql/gpdb/9.1

Re: [pgAdmin4][patch] trigger's when clause related fixes

2020-06-30 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 29, 2020 at 2:15 PM Zhang, Jie wrote: > Hi, all > > [Incident] > '()' appears twice in trigger's when clause​. > > [scenario 1] > The step is as follow: > 1) The SQL to create the trigger is as follows. > - > CREATE

pgAdmin 4 commit: Added support for schema level restriction. Fixes #55

2020-06-30 Thread Akshay Joshi
Added support for schema level restriction. Fixes #5583 Allow user to edit the connection properties when the database server is already connected. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c873218c3279a12d97852f06d3d64fd33f6346d8 Author

pgAdmin 4 commit: Fixed SonarQube code smell 'Variables should not be s

2020-06-30 Thread Akshay Joshi
Fixed SonarQube code smell 'Variables should not be shadowed'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c052876773c1571d5c42b90506e257518555611 Author: Satish V Modified Files -- web/pgadmin/misc/bgprocess/static/js/bgproc

pgAdmin 4 commit: Fixed SonarQube code smells 'Refactor this function t

2020-06-30 Thread Akshay Joshi
Fixed SonarQube code smells 'Refactor this function to reduce its Cognitive Complexity'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6713bc068bd53ee7b95f27c21abf626b6fd70656 Author: Nikhil Mohite Modified Files -- .../databas

Re: Support schema level restrictions and edit connection properties when already connected.

2020-06-30 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jun 30, 2020 at 5:46 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay/ Team, > > PFA updated patch for [RM-5583]. > > > Regards, > Nikhil Mohite. > > On Tue, Jun 30, 2020 at 5:06 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> H

Re: Patch for SonarQube code scan fixes

2020-06-30 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 29, 2020 at 7:48 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Sequences files: > >- Refactor this function to reduce its Cognitive Co

Re: Re- [SonarQube][patch]- codesmell

2020-06-30 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jun 30, 2020 at 11:12 AM Satish V wrote: > Hi Hackers, > > Please find the patch which fixes the code smell issues related to the > rule "Variables should not be shadowed". > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect*

Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff

2020-06-30 Thread Pradip Parkale
Hi Akshay, Please find the attached patch for following fixes, - RM5631 - [RLS Policy] can't execute an empty query. - In case of more than one policy, all the headers are showing as a comment on top of policy DDL in schema diff. - Fixed - If the policy event is different for source a

[pgAdmin][RM4235]: Tab indent on a selection of lines is deleting content

2020-06-30 Thread Nikhil Mohite
Hi Team, I have done fixes for RM-4235. Details as follows: 1. Resolved issue with tab indent when a user set "use spaces == true" in preferences > Querytool > Editor > Use spaces. 2. Making sure the behavior is the same when "user spaces" setting to "true" or "false". PFA patch. Regards, Nikhi

pgAdmin 4 commit: Do not let browser autocomplete the password field wh

2020-06-30 Thread Ashesh Vashi
Do not let browser autocomplete the password field while connecting a database server. Set the autocomplete attribute of the password field to 'new-password' to let browser know, we require a new password for the password, and do not autocomplete it. Branch -- master Details --- https://

pgAdmin 4 commit: Fix the dialog size when zoom level is changed of the

2020-06-30 Thread Ashesh Vashi
Fix the dialog size when zoom level is changed of the browser. The screen.width & screen.height does not reflect the values of the height and width respectively when zoom level is changed for the browser. It is better to review the calculated height and width based on the window.innerHeight and wi

[pgAdmin4][Patch] - SonarQube Issues07 (Variables should not be shadowed)

2020-06-30 Thread Yogesh Mahajan
Hi, Please find a patch which fixes issues related to rule- 'Variables should not be shadowed'. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix7_v1.patch Description: Binary data