Re: [pgAdmin][patch] SonarQube reported issues tagged - unused

Thanks, patch applied. On Thu, Jun 25, 2020 at 10:10 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix SonarQube issues with the tag "unused". All > the unused variables, assignments, code comments are fixed. > > -- > Thanks and Regards

pgAdmin 4 v4.23 released

The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.23. This release of pgAdmin 4 includes 19 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_23.html. We are pleased to announce a numbe

pgAdmin 4 commit: Tag REL-4_23 has been created.

Tag REL-4_23 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_23 Log Message --- Tag v4.23

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

Hi, Please find an updated patch. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Thu, Jun 25, 2020 at 12:26 PM Akshay Joshi wrote: > Hi Yogesh > > Jasmin tests are failing, please fix and resend the patch. > > On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahaj

Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop)

Hi, Please find patch fixing the issues related to below rules - 1.A conditionally executed single line should be denoted by indentation, 2.A "while" loop should be used instead of a "for" loop. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Thu, Jun 25, 202

[pgAdmin4][Patch] SonarQube Fixes

Hi, Please find the attached patch to fix the code smells having rule (PYTHON) NESTED BLOCKS OF CODE SHOULD NOT BE LEFT EMPTY. Thanks, Khushboo sonarqube_fixes_nested_code_blocks.patch Description: Binary data

[pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff

Hi Hackers, Please find the attached patch for RLS policy support in schema diff. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM-5601.patch Description: Binary data

Patch for SonarQube code scan.

Hi Team, I have fixed some code smell issues in SonarQube scan. 1. Code smells in packages init file. 2. Code smells in function init file (not fixed all code smell will send new path for it). Regards, Nikhil Mohite. sonar_qube_code_smell_fixes.patch Description: Binary data

Re: Patch for SonarQube code scan.

Hi Nikhil, Can you please provide the details of the issue provided by SonarQube (so review would be easy) ? Thanks, Khushboo On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in SonarQube scan. > 1. Code sm

Re: Patch for SonarQube code scan.

Hi Khushboo, Details as follows: 1. Package files: 1. Refactor this function to reduce its Cognitive Complexity from 40 to the 15 allowed. 2. Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 2. Functions files: 1. Rename this local variable "argString" to mat

Re: Patch for SonarQube code scan.

On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Khushboo, > > Details as follows: > 1. Package files: > > 1. Refactor this function to reduce its Cognitive Complexity from 40 to > the 15 allowed. > 2. Refactor this function to reduce its Cognitive Compl

Re- [SonarQube][patch]- tagged suspicious, convention

Hi Hackers, Please find the patch which resolves the SonarQube scan issue stated below. 1.Method/Field names should comply with a naming convention. 2.Conditionals should start on new lines conditionals_and_rename.patch Description: Binary data