pgAdmin 4 commit: Cleanup some duplicated styles.

2020-06-17 Thread Dave Page
Cleanup some duplicated styles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ca99129873d01081e6ca0055dceaccb0cc66fe2 Modified Files -- docs/en_US/theme/pgadmin4/static/style.css | 10 +- 1 file changed, 1 insertion(+), 9

pgAdmin 4 commit: Cleanup some variable naming.

2020-06-17 Thread Dave Page
Cleanup some variable naming. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa15d2a7e2b32e3cd1c1e61634caa99b78a99a0c Modified Files -- pkg/mac/dmg-license.py | 28 ++-- 1 file changed, 14 insertions(+), 14

pgAdmin 4 commit: Correct URL and versions.

2020-06-17 Thread Dave Page
Correct URL and versions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6525f25a227d603b2b1137eacb00ed2df2db0f78 Modified Files -- tools/dependency_inventory.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Correct function naming.

2020-06-17 Thread Dave Page
Correct function naming. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f5e8962b5fa66f00e2d790a5a2d3cc65787e4e8 Modified Files -- tools/copyright_updater.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: 1) Added option to ignore the whitespaces while compa

2020-06-17 Thread Akshay Joshi
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468 2) Added server group name while selecting servers in schema diff. Fixes #5500 3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584 Branch -- master Detai

[pgAdmin4][Patch] - Issue fixes reported by SonarQube -2

2020-06-17 Thread Yogesh Mahajan
Hi, Please find patching and fixing issues related to shadowing variables of some more js files. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix3_v1.patch Description: Binary data

pgAdmin 4 commit: Fixed issue related to shadowing variables reported b

2020-06-17 Thread Akshay Joshi
Fixed issue related to shadowing variables reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7c12ade161ebe852b8e05cca7eb9120a9c4819de Author: Yogesh Mahajan Modified Files -- .../servers/tablespaces/static/js/

Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions

2020-06-17 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jun 17, 2020 at 10:55 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the patch for few more similar issues. Please review. > > On Tue, Jun 16, 2020 at 11:16 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks,

pgAdmin 4 commit: Fixed vulnerabilities and few design suspicions where

2020-06-17 Thread Akshay Joshi
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df05efd7d9c5981d254f3fea3d025e14755af2db Author: Aditya Toshniwal Modified F

Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube -2

2020-06-17 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jun 16, 2020 at 5:52 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patching fixing issues related to shadowing variables of some > more js file. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-

Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube -2

2020-06-17 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jun 17, 2020 at 4:34 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patching and fixing issues related to shadowing variables of > some more js files. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone:

pgAdmin 4 commit: Fixed some sonarqube issues.

2020-06-17 Thread Akshay Joshi
Fixed some sonarqube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ed1e1e5b6d07751aca1db3e29d28d146930f14f Modified Files -- .../servers/databases/schemas/functions/static/js/procedure.js| 2 +- .../constraints/check_

[pgAdmin][patch] Sonarqube issues tagged as redundant

2020-06-17 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix sonarqube issues tagged as redundant. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" sonarqube.redundant.patch Description: Binary data

pgAdmin 4 commit: Fixed redundant tagged issue reported by SonarQube.

2020-06-17 Thread Akshay Joshi
Fixed redundant tagged issue reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0490a54b7db6b07c5a4df1b83a18e1ff833401e Author: Aditya Toshniwal Modified Files -- .../databases/extensions/static/js/extension.j

Re: [pgAdmin][patch] Sonarqube issues tagged as redundant

2020-06-17 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jun 18, 2020 at 10:36 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix sonarqube issues tagged as redundant. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Softwar

Re-[Sonarqube]- Clumsy code

2020-06-17 Thread Satish V
Hi Hackers, Please find the patch in the attachment which resolves below issue. 1.Replace this if-then-else statement by a single return statement. Kindy review and share the changes, if required Thanks, Sathish V if_else_reduction.patch Description: Binary data

[pgAdmin4][Patch] - Issue fixes reported by SonarQube - 4 (Rule Comma operator should not be used)

2020-06-17 Thread Yogesh Mahajan
Hi, Please find patching and fixing issues related to "Rule *Comma operator should not be used*" across the project. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix4_v1.patch Description: Binary data