Reg-[Sonarqube]CodeSmell issues

2020-06-16 Thread Satish V
Hi Hackers, Please find the patch in the attachment which resolves below issues 1.Replace this if-then-else statement by a single return statement.(clumsy) 2."switch" statements should have at least 3 "case" clauses. (bad practise) Kindly review and share the changes, if required. Thanks Sathis

pgAdmin 4 commit: Fixed runtime issues reported by SonarQube.

2020-06-16 Thread Akshay Joshi
Fixed runtime issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf64e2c97c764763186569280afeaedafa342590 Modified Files -- runtime/ConfigWindow.cpp | 6 +- runtime/ConfigWindow.h | 1 + runtime

pgAdmin 4 commit: Fixed following issues reported by SonarQube:

2020-06-16 Thread Akshay Joshi
Fixed following issues reported by SonarQube: 1) Replace this if-then-else statement by a single return statement. (clumsy) 2) 'switch' statements should have at least 3 'case' clauses. (bad practice) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdi

Re: Reg-[Sonarqube]CodeSmell issues

2020-06-16 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jun 16, 2020 at 12:49 PM Satish V wrote: > Hi Hackers, > > Please find the patch in the attachment which resolves below issues > 1.Replace this if-then-else statement by a single return > statement.(clumsy) > 2."switch" statements should have at least 3 "case" clau

[pgAdmin4][Patch] - Issue fixes reported by SonarQube -2

2020-06-16 Thread Yogesh Mahajan
Hi, Please find patching fixing issues related to shadowing variables of some more js file. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix2_v1.patch Description: Binary data

Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions

2020-06-16 Thread Aditya Toshniwal
Hi, Attached is the patch for few more similar issues. Please review. On Tue, Jun 16, 2020 at 11:16 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Jun 16, 2020 at 10:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch will fix