Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true

2020-06-14 Thread Satish V
Hi Hackers, Please find the patch in the attachment which clears the sonarqube error, related to expressions evaluated to true/false always. Kindly review the patch and share the changes required Thanks, Sathish V refactor_always_evaluate_to_true.patch Description: Binary data

Re: [pgAdmin][patch] Clumsy coding related fixes

2020-06-14 Thread Aditya Toshniwal
Hi, Few more clumsy coding related fixes. Please review. On Fri, Jun 12, 2020 at 3:25 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jun 12, 2020 at 11:40 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for some clumsy

Re: [pgAdmin][patch] Clumsy coding related fixes

2020-06-14 Thread Aditya Toshniwal
Hi, Please ignore the previous patch, attached is the updated patch. On Mon, Jun 15, 2020 at 11:50 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Few more clumsy coding related fixes. > Please review. > > On Fri, Jun 12, 2020 at 3:25 PM Akshay Joshi < > akshay.jo...@en