[pgAdmin][RM5335]: [Code Coverage] Improve API test cases for Triggers and Compound Triggers

Hi Hackers, Please find the attached patch to improve the code coverage for 'Triggers' and 'Compund_triggers' node. Command to run the compound triggers node test cases - - python runtests.py --pkg browser.server_groups.servers.databases.schemas.tables.compound_triggers.tests Command to

pgAdmin 4 commit: Improve code coverage and API test cases for Triggers

Improve code coverage and API test cases for Triggers and Compound Triggers. Fixes #5335 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d6cd19b374c71d9b90e5d50c04d937e6ec34dbd Author: Pradip Parkale Modified Files -- docs/en_US

Re: [pgAdmin][RM5335]: [Code Coverage] Improve API test cases for Triggers and Compound Triggers

Thanks, patch applied. On Fri, May 15, 2020 at 12:31 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to improve the code coverage for 'Triggers' > and 'Compund_triggers' node. > > Command to run the compound triggers node test cases - >

[pgAdmin][RM5333] : [Code Coverage] Improve API test cases for Indexes

Hi, Please find the attached patch to improve index node code coverage. Command to run the test cases - - python runtests.py --pkg browser.server_groups.servers.databases.schemas.tables.indexes.tests Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM533

Re: RM5525: Cleanup and refactor the macOS build scripts

patch -p0 < ~/Downloads/RM5525.patch On Fri, May 15, 2020 at 6:46 AM Akshay Joshi wrote: > Hi Dave > > Unable to apply the patch. Tried from pgadmin source folder as well as > from the pkg folder. > I run git apply . > > On Thu, May 14, 2020 at 7:01 PM Dave Page wrote: > >> Patch attached. Plea

[pgAdmin4][Patch] - RM 5452 improvement

Hi, In order to find who query what, we have added pgadmin user identity ( current_user.email ) in the log file. (RM 5452). In this patch, current_user.email is changed to current_user.username because there are possibilities that ldap user may not have an email address. Thanks, Khushboo RM_5

pgAdmin 4 commit: Add a script for generating a repo RPM.

Add a script for generating a repo RPM. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=762784d2b5675bbe5a7a4eec7e503ae77161ab98 Modified Files -- pkg/redhat/repo-rpm.sh | 105 + 1 fil

Re: RM5525: Cleanup and refactor the macOS build scripts

Hi Dave Following are my review comments: - Code alignment is needed for some places in *build-functions.sh. *I have shellcheck installed in PyCharm and it is showing too many warnings in this file, not sure we should fix those or not - Foll

Re: RM5525: Cleanup and refactor the macOS build scripts

Hi On Fri, May 15, 2020 at 12:37 PM Akshay Joshi wrote: > Hi Dave > > Following are my review comments: > >- Code alignment is needed for some places in *build-functions.sh. *I >have shellcheck installed in >PyCharm and it is showing too many