[pgAdmin][RM5410] Package Body is not being removed

Hi Hackers RM #5410 has been reopened. *Problem Statement*: When we change the definition of the package header it will delete the existing package body. I confirmed that this is the expected behavior in the EDB Postgres Advanced Server. Attached is the patch to just popped up the warning message

Re: [pgAdmin][RM5410] Package Body is not being removed

I will be reviewing this patch. On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi wrote: > Hi Hackers > > RM #5410 has been reopened. *Problem Statement*: When we change the > definition of the package header it will delete the existing package body. > I confirmed that this is the expected behavior i

[pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

Hi, Please find an updated patch that fixes a bug in 'next_schedule' function where minute should be extracted instead of year for calculation. Issue found by: Vik Fearing Please find the attached patch that fixed the issue in respective pgagent files and updated pgagent for 4.2 version. Do rev

[pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

Hi Hackers, Attached is the patch to add the "System XXX?" property to the object types where it was missing. I've also attached a allobjects.sql file to create all types of objects under a database for PGv12 which might help to test. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmi

Re: [pgAdmin][RM5410] Package Body is not being removed

Patch looks good to me. Please go ahead and commit the code. On Thu, Apr 23, 2020 at 4:25 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > I will be reviewing this patch. > > On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers >> >

pgAdmin 4 commit: Fixed an issue where columns names should be visible

Fixed an issue where columns names should be visible in the order of their creation in the browser tree. Fixes #5043 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2e29f3fd6d26542df7ea3d684960c69de1039db8 Author: Satish V Modified Files ---

pgAdmin 4 commit: A warning message will be displayed only when the pac

A warning message will be displayed only when the package header is changed for EPAS packages. Fixes #5410 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b5c90e379d4a94bac5e9359cbe2f5e9ca8d9c45 Modified Files -- .../schemas/pack

pgAdmin 4 commit: Ensure all object types have a System XXX? property.

Ensure all object types have a System XXX? property. Fixes #1257 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dfb74904ed54db96f57ddae304dbc286428e943e Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_21.rst

Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

Thanks, patch applied. On Thu, Apr 23, 2020 at 5:04 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add the "System XXX?" property to the object > types where it was missing. > I've also attached a allobjects.sql file to create all types

Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Thanks, patch applied. On Thu, Apr 23, 2020 at 12:02 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello, > > Patch looks good to me. Newly created columns sorted according to their > creation order without context refresh. > > Thanks! > > On Thu, Apr 23, 2020 at 10:13 AM navnath

[pgAdmin][RM4180] Mouse click does not select object in Browser unless pointer is over object

Hi Hackers, Attached patch will allow the tree objects to be selected on the full row. Currently, it works only on the expand/collapse icon and the object text. I went through the acitree code and found an option - "fullRow" to enable it. However, changes were required to CSS to fit our current v

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

Hi Hackers, After fixing the issue reported by Shubham, I observed that sometimes browser is getting hanged and sometimes ViewData grid is getting disappear, I suspect its due to the number of rows to update on slick grid after fetching next of rows. FYI, I was running a query which was returning 1

pgAdmin 4 commit: Fixed mouse click issue where it does not select an o

Fixed mouse click issue where it does not select an object in Browser unless the pointer is over the object. Fixes #4180 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=90849fe29b99914308c7f46ac99223ff1b417d76 Author: Aditya Toshniwal Modifi

pgAdmin 4 commit: Reverting patch for RM #3269.

Reverting patch for RM #3269. We observed that sometimes the browser is getting hanged and sometimes the ViewData grid is getting disappear. We suspect its due to the number of rows to update on the slick grid after fetching next of rows. Branch -- master Details --- https://git.postgres

Re: [pgAdmin][RM4180] Mouse click does not select object in Browser unless pointer is over object

Thanks, patch applied. On Thu, Apr 23, 2020 at 6:59 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will allow the tree objects to be selected on the full row. > Currently, it works only on the expand/collapse icon and the object text. > > I went t

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

Thanks, patch applied. On Fri, Apr 24, 2020 at 10:49 AM Nagesh Dhope wrote: > Hi Hackers, > After fixing the issue reported by Shubham, I observed that sometimes > browser is getting hanged and sometimes ViewData grid is getting disappear, > I suspect its due to the number of rows to update on s