Re: [Patch][pgAdmin4]: Fix pgagent issues

Hi Neel RESQL test cases are failing on my machine due to different timezone - '2020-04-14 01:11:31-07'::timestamp with time zone, '2020-04-15 01:11:34-07'::timestamp with time zone, ? - ^^ ^ - ^ ^ ^ + '2020-04-14 13:41:31+0

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

Hi Navnath On Tue, Apr 21, 2020 at 12:21 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Hackers, > It's related to applying data sorting on table data by primary > key. > With the existing implementation, we can view the table's data using 4 > options with the differ

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

Hi Yogesh, Below are the review comments- 1. runtests.py a. The exception traceback logic at line number 653 in runtests.py is not correct since it is particular to the thread but there is much more code in that block which can throw some exception. b. line number 447 -> The drop_database func

pgAdmin 4 commit: Fixed an issue wherein grant wizard the last object i

Fixed an issue wherein grant wizard the last object is not selectable. Fixes #4545 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3d516101a446e04d09ad34f2fd00b76216ad2fb2 Author: Pradip Parkale Modified Files -- docs/en_US/relea

pgAdmin 4 commit: Fixed an issue where slider jumps up when new rows ge

Fixed an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool. Fixes #3269 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d4f3c07c777d57cf0e89af8ed06b0e7886f37ab Author: Nagesh Dho

pgAdmin 4 commit: Fixed the rightmost and bottom tooltip crop issues in

Fixed the rightmost and bottom tooltip crop issues in the explain query plan. Fixes #5352 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e30a99937737e1e86f9ee93ea1bccf97f1a0198 Author: Yogesh Jain Modified Files -- docs/en_US/r

Re: [pgAdmin][RM4545]: In grant wizard, last object is not selectable

Thanks, patch applied. On Mon, Apr 20, 2020 at 7:44 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch to fix the issue in the grand wizard. > > This patch will fix: > >1. If we try to select the last object type in grant wizard, it's not >ge

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

Thanks, patch applied. On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope wrote: > Hi Hackers, > The attached patch fixes an issue where slider jumps up when new rows get > loaded while scrolling down in the DataView panel in the query tool. > Fix uses *rows_affected *field to create dummy rows (Apar

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Thanks, patch applied. On Mon, Apr 20, 2020 at 8:05 PM Yogesh Jain wrote: > Hi Hackers, > > Attached is the patch to fix the rightmost & bottom tooltip crop issues in > the explain query plan. > > FYI : While explaining a large query if we hover the rightmost or bottom > icon the tooltip is crop

Re: [Patch][pgAdmin4]: Fix pgagent issues

Hi Akshay, Please find the attached update patch with the fix. Also fixed the Roles resql test cases as it was failing due to timezone change. Thanks, Neel Patel On Tue, Apr 21, 2020 at 12:32 PM Akshay Joshi wrote: > Hi Neel > > RESQL test cases are failing on my machine due to different timez

pgAdmin 4 commit: Added job step and job schedule disable icons to iden

Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636 Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623 Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356 Branch -- master Deta

pgAdmin 4 commit: Fixed following issues for packages:

Fixed following issues for packages:   1) Removing the package header removes the body as well. 2) Schema is not visible on the properties dialog.   3) Reverse engineering SQL and Create script not showing schema-qualified packages. Fixes #5410 Branch -- master Details --- https://git

Re: [Patch][pgAdmin4]: Fix pgagent issues

Thanks, patch applied. On Tue, Apr 21, 2020 at 4:40 PM Neel Patel wrote: > Hi Akshay, > > Please find the attached update patch with the fix. > Also fixed the Roles resql test cases as it was failing due to timezone > change. > > Thanks, > Neel Patel > > On Tue, Apr 21, 2020 at 12:32 PM Akshay J

[SSPI] Windows group support

Hi, I have some code that I've been using in production that supports adding and authenticating Windows groups via the pg_ident file. It has a new indicator (+), that signifies the identifier is a Windows group, as in the following example: # MAPNAME SYSTEM-USERNAME PG-USERNAME "Users" "

Minor request :)

Hello It would be great to have something in the tags on the login page, so Keepass is able to use it as reference for the auto-type login. https://github.com/postgres/pgadmin4/blob/8180403f976ee0d759631e7539205548dbdd2d6c/web/pgadmin/templates/base.html#L14 ... seems not to set anything on the

Re: Minor request :)

Hi, On Tue, Apr 21, 2020 at 7:03 PM wrote: > Hello > > It would be great to have something in the tags on the > login page, so Keepass is able to use it as reference for the auto-type > login. > Please log your request @ https://redmine.postgresql.org/projects/pgadmin4 . Thanks, Khushboo > >

Re: [pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

Hi, Please find a patch, which will allow copying *[null]* and *[default] cell values.* RM3947_v3.patch Description: Binary data

[pgAdmin4][Patch] - RM 3900 - Delete/Drop option is disabled for the constraints

Hi, Please find the attached patch to fix the RM #3900 - Delete/Drop option is disabled for the constraints. - Implemented multiple drop/delete functionality for the Table constraints. Thanks, Khushboo RM_3900.patch Description: Binary data

Exclude RESQL test cases

Hello Hackers, Please review the small patch to exclude RESQL test cases. resql param is added to --exclude. Thanks! -- Regards, Navnath Gadakh exclude_resql_tests_v1.patch Description: Binary data