Re: pgAdmin 4 - next gettext usage fixes

2020-04-19 Thread Libor M.
Hi, I sending patch for slightly modified the use of gettext: - fixed `%` vs. `.format()` - unified texts and usage `%s` vs. `{}`/`{0}` - improved text sentences for translate - added gettext for next texts Best regards, Libor M. E-mail: libor...@gmail.com GitHub: https://github.com/liborm85 čt

Re: pgAdmin is freezing

2020-04-19 Thread Khushboo Vashi
Hi, On Sat, Apr 18, 2020 at 1:41 AM Nagaraj Raj wrote: > Hi, > > pgAdmin is freezing for other activities when dropping any table or index > if command is held because of any lock occurring. In this state unable to > access any other objects like stats, SQL statements, descriptions or query > to

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

2020-04-19 Thread Khushboo Vashi
Hi Amol, The patch is working fine and looks good to me however some code related review comments: 1. The test case is particularly written for Temporary table with Commit Drop, so please mention it in the comments. 2. Also, the class TestQueryUpdatableResultset is been inherited, so no need to r

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-19 Thread Khushboo Vashi
Hi Navnath, Review comments: 1. If we have multiple Primary keys, then we should include all the keys into the Order by clause. 2. In the Preferences dialog, please put this option in the Query Tool > Options instead of Result Grid and also change the Label. 3. Please optimize the code, as I can

Re: [pgAdmin][RM5396] Unable to locate this object in the browser in search objects

2020-04-19 Thread Akshay Joshi
Hi Aditya Jasmine tests are failing. Please fix and resend the patch. On Fri, Apr 17, 2020 at 6:49 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issues raised in the RM and other issues > which I encountered while fixing. Follo

Re: [pgAdmin][RM5396] Unable to locate this object in the browser in search objects

2020-04-19 Thread Aditya Toshniwal
Hi, Attached is the updated patch to also make required changes in the test cases. Please review. On Mon, Apr 20, 2020 at 11:28 AM Akshay Joshi wrote: > Hi Aditya > > Jasmine tests are failing. Please fix and resend the patch. > > On Fri, Apr 17, 2020 at 6:49 PM Aditya Toshniwal < > aditya.tosh