pgAdmin 4 commit: Added schema-qualified dictionary names in FTS config

2020-04-16 Thread Akshay Joshi
Added schema-qualified dictionary names in FTS configuration to avoid confusion of duplicate names. Fixes #4709 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7493649893c167e2923ca8a42760baa46ba9c255 Author: Ganesh Jaybhay Modified Files --

pgAdmin 4 commit: Ensure the DROP statements in reverse engineered SQL

2020-04-16 Thread Akshay Joshi
Ensure the DROP statements in reverse engineered SQL are properly quoted for all objects. Fixes #4440 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6cab7b421db3bae0ad4c3f6ac79cc81066a6d14 Author: Shubham Agarwal Modified Files ---

pgAdmin 4 commit: Some minor gettext and format fixes.

2020-04-16 Thread Akshay Joshi
Some minor gettext and format fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8254e9f030a4c951c4600378a67a62c7b0692aba Author: Libor M Modified Files -- .../server_groups/servers/databases/event_triggers/__init__.py

pgAdmin 4 commit: Ensure that Constraint Trigger, Deferrable, Deferred

2020-04-16 Thread Akshay Joshi
Ensure that Constraint Trigger, Deferrable, Deferred option should be disabled when the user selects EDB-SPL function for the trigger. Fixes #4957 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=738c421edf6b3aa90b83216d3b32e9f29dd779e4 Author:

pgAdmin 4 commit: Fixed an issue where the Mode cell of argument grid d

2020-04-16 Thread Akshay Joshi
Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. Fixes #5375 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eec2cfd5dd055bf3982eb3d0fa5294d7a18f8b90 Author: Murtuza Zabuawala Modified F

Re: [pgAdmin4][RM#5375] "Mode" cell does not appear completely in the function dialog (Firefox specific issue)

2020-04-16 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 15, 2020 at 4:29 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where the Mode cell from arguments grid does > not appear completely in the Functions dialog. > > > -- > Regards, > Murtuza Zabuawala > Enterp

Re: [pgAdmin4 Patch - RM 4440]

2020-04-16 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 15, 2020 at 4:37 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > > > On Wed, Apr 15, 2020 at 4:31 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Apr 15, 2020 at 4:29 PM Shubham Agarwal < >> shubham.agar...@enterp

Re: [pgAdmin4][Patch] - RM 4957 - Constraint Trigger, Deferrable, Deferred option should be disbled if user select EDB-SPL function for trigger for EPAS.

2020-04-16 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 15, 2020 at 4:54 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Wed, Apr 15, 2020 at 3:58 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushb

Re: pgAdmin 4 - next gettext usage fixes

2020-04-16 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 15, 2020 at 5:17 PM Libor M. wrote: > Hi, > next minor gettext and format fixes in patch. > > Best regards, > > Libor M. > > E-mail: libor...@gmail.com > GitHub: https://github.com/liborm85 > > st 15. 4. 2020 v 13:17 odesílatel Akshay Joshi > napsal: > > > > T

pgAdmin 4 commit: Fixed documentation error.

2020-04-16 Thread Akshay Joshi
Fixed documentation error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0dd1cb3fc162c694fc644c3317a52396cdc54199 Modified Files -- docs/en_US/procedure_dialog.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

2020-04-16 Thread Khushboo Vashi
Hi, Patch looks good to me. Thanks, Khushboo On Thu, Apr 16, 2020 at 12:07 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Khushboo, > > Please find the modified patch. I have removed the length from the data > types. Test cases also passing on all Postgres versions. > Thanks!

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

2020-04-16 Thread navnath gadakh
Hi, I think I am not the right person to review this patch now as I already reviewed this code offline in the last week. I know the approached Yogesh has followed, also given some review comments on it. Someone else please review it. Thanks! On Mon, Apr 13, 2020 at 2:49 PM Akshay Joshi wrote: >

pgAdmin 4 commit: Fixed copy-paste row issues in View/Edit Data. Fixes

2020-04-16 Thread Akshay Joshi
Fixed copy-paste row issues in View/Edit Data. Fixes #3947 1) Copy table rows across two or more active query tool sessions. 2) Copied rows can be pasted multiple times without selecting a row in the query tool grid. 3) Adds an empty row at the end in the query tool grid after pasting rows.

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

2020-04-16 Thread Akshay Joshi
Thanks, patch applied. On Thu, Apr 16, 2020 at 1:53 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Patch looks good to me. > > Thanks, > Khushboo > > On Thu, Apr 16, 2020 at 12:07 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> Please

pgAdmin 4 commit: Fixed internal server error when the database server

2020-04-16 Thread Akshay Joshi
Fixed internal server error when the database server is logged in with non-super user. Fixes #5400 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc1e32a632353d6e39652b4b25ea020ac0534ee9 Author: Aditya Toshniwal Modified Files -

pgAdmin 4 commit: Ensure that text larger than underlying field size sh

2020-04-16 Thread Akshay Joshi
Ensure that text larger than underlying field size should not be truncated automatically. Fixes #5210 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c0a2f1f24dfde8272dca4ff77eda25cad28b3ea8 Author: navnath gadakh Modified Files

Re: [pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

2020-04-16 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 15, 2020 at 1:39 PM Nagesh Dhope wrote: > Please find an updated patch, which handles field separator and quote > character from *Result Grid *preferences. > > On Wed, Apr 15, 2020 at 10:18 AM Nagesh Dhope < > nagesh.dh...@enterprisedb.com> wrote: > >> Hi Hacke

Re: [pgAdmin][RM5400] An unexpected occurred: INTERNAL SERVER ERROR message displayed if database server connected with non super user

2020-04-16 Thread Akshay Joshi
Thanks, patch applied. On Thu, Apr 16, 2020 at 11:33 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to replace the usage of pg_user_mapping table with > pg_user_mappings view. pg_user_mapping is not publicly accessible. > Changes are done f

[pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-16 Thread navnath gadakh
Hi Dave/Team, This patch is related to the default sort order for the view table data. In pgAdminIII default ordering is by primary key and this is not working in pgAdminIV. I have attached the patch with the back end code. Please review it. *Question*: There is one suggestion on https:

[pgAdmin][RM4573] Download csv as .csv when delimeter set comma(,)

2020-04-16 Thread Nagesh Dhope
Hi Hackers, This patch allows user to download CSV as a '.csv' file if delimiter character is set to comma(,) else it will download it as '.txt' file. This patch also contains test cases for some missing scenarios for download CSV API. -- Thanks, Nagesh RM4573.patch Description: Binary data

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-16 Thread Khushboo Vashi
Hi Navnath, On Thu, Apr 16, 2020 at 4:38 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave/Team, > This patch is related to the default sort order for the view > table data. In pgAdminIII default ordering is by primary key and this is > not working in pgAdminIV. > I

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-16 Thread Dave Page
On Thu, Apr 16, 2020 at 12:08 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave/Team, > This patch is related to the default sort order for the view > table data. In pgAdminIII default ordering is by primary key and this is > not working in pgAdminIV. > I have attache

[pgAdmin4][RM#3495] Do not check for binary content if BOM marker is present in the file

2020-04-16 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where the user was not able to load the file in the Query tool which contains the BOM marker, The sample file with BOM marker is already attached in the RM. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company