Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries

Hi Ganesh As per my understanding, the dictionary names from "pg_catalog" should not be schema-qualified. Please make appropriate changes and send the patch again. @Dave/@Ashesh thoughts? On Tue, Apr 14, 2020 at 5:37 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > >

Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries

On Wed, Apr 15, 2020 at 8:25 AM Akshay Joshi wrote: > Hi Ganesh > > As per my understanding, the dictionary names from "pg_catalog" should not > be schema-qualified. Please make appropriate changes and send the patch > again. > > @Dave/@Ashesh thoughts? > Maybe I'm missing something, but I don't

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi Amol, On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > I am reviewing this patch. > > Thanks, > Khushboo > > On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare < > amol.vyavah...@enterprisedb.com> wrote: > >> Hi Hackers, >> Attached is the patch

Re: pgAdmin 4 - next gettext usage fixes

Hi Aditya I think the fix is incorrect. .format method should be applied after gettext() like gettext().format(). Please check for other places too and send the updated patch. On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers/Libor, > > Th

Re: [pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

Please find an updated patch, which handles field separator and quote character from *Result Grid *preferences. On Wed, Apr 15, 2020 at 10:18 AM Nagesh Dhope wrote: > Hi Hackers, > Please find a patch which fixes, > >1. Copy table rows across two or more active query tool sessions. >2. C

pgAdmin 4 commit: Correct the build script whereby mistake we have remo

Correct the build script whereby mistake we have removed the theme components from the source tree while building. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25553b11ed98f3af47f4f08b6a875f77056a513b Author: Neel Patel Modified Files ---

pgAdmin 4 commit: Fixed an issue where the mode is not shown in the pro

Fixed an issue where the mode is not shown in the properties dialog of functions/procedures if all the arguments are IN arguments. Fixes #5387 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8654d6cf4344f35a0999f1adf2b5965bdda3b283 Author: Shu

pgAdmin 4 commit: Fixed following issues for Procedures:

Fixed following issues for Procedures: 1) Change comments on the procedure with arguments as a procedure can be overloaded. Note that on EPAS servers, procedure overloading works only for v11+. 2) The save button of a procedure dialog is enabled without any change. 3) Fixed formatting o

Re: [pgAdmin][RM4873] Change comment of a procedure with arguments

Thanks, patch applied. On Tue, Apr 14, 2020 at 5:52 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch to fix following issues: > 1) Change comment of procedure with arguments as a procedure can be > overloaded. Note that on EPAS servers, procedu

Re: [pgAdmin4 - Bug #5387]

Thanks, patch applied. On Tue, Apr 14, 2020 at 4:01 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA the patch for displaying mode in properties of func/proc if all args > are "IN" > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgr

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Sure, will do that. On Wed, Apr 15, 2020 at 1:33 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Amol, > > On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> I am reviewing this patch. >> >> Thanks, >> Khushboo >> >> On Wed,

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hello Hackers, On Tue, Apr 14, 2020 at 5:14 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Navnath, > > You have compared the column's internal size with the length of the value > given by the user. > For example, column having integer would have internal size 4 and if I > give

Re: pgAdmin 4 - next gettext usage fixes

Hi, Please find the updated patch. On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi wrote: > Hi Aditya > > I think the fix is incorrect. .format method should be applied after > gettext() like gettext().format(). Please check for other places too and > send the updated patch. > > On Wed, Apr 15, 20

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

On Wed, Apr 15, 2020 at 2:48 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Hackers, > > > On Tue, Apr 14, 2020 at 5:14 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Navnath, >> >> You have compared the column's internal size with the length of the valu

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hi, I think this is not a bug. From what I can see, the query - "UPDATE public.account SET username = 'username-test-123'::character varying(5) WHERE user_id = 1;" will not throw any error from psql. The same query is fired by pgAdmin, hence no error. To get an error we need to remove the typecas

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hi, I think we should remove the type cast from query during update and whatever error is thrown should be shown to UI as per scenario 3. Thanks, Neel Patel On Wed, Apr 15, 2020 at 3:06 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 15, 2020 at 2:48 PM navnath gad

Re: [pgAdmin4][Patch] - RM 4957 - Constraint Trigger, Deferrable, Deferred option should be disbled if user select EDB-SPL function for trigger for EPAS.

Hi Khushboo The fix is not correct, as per RM, we should disable Constraint Trigger, Deferrable, Deferred option when the user selects the "Inline EDB-SPL" function. With this patch, it is disabled for EPAS. Please fix and resend the patch. On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi < khushb

[pgAdmin4 Patch - RM 4440]

Hi Team, PFA patch containing the fix and the resql test cases. -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company

Re: [pgAdmin4 Patch - RM 4440]

On Wed, Apr 15, 2020 at 4:29 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA patch containing the fix and the resql test cases. > > You forgot to attach the patch. > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Compan

Re: [pgAdmin4 Patch - RM 4440]

On Wed, Apr 15, 2020 at 4:31 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 15, 2020 at 4:29 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> PFA patch containing the fix and the resql test cases. >> >> You forgot to attach the patch.

pgAdmin 4 commit: Make changes to use gettext() function correctly.

Make changes to use gettext() function correctly. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31a929388b3adb153a3b09be284dce3869bb39fe Author: Aditya Toshniwal Modified Files -- web/pgadmin/__init__.py

pgAdmin 4 commit: Added alert message to Reset Layout if any of the pan

Added alert message to Reset Layout if any of the panels from Query Tool failed to load. Fixes #5366 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed0a596286a7f0fef741f91633e76b39e1ca338f Author: Khushboo Vashi Modified Files -

pgAdmin 4 commit: Fixed python exception error when user tries to downl

Fixed python exception error when user tries to download the CSV and there is a connection issue. Fixes #4858 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c41da41efe88cccd0df9ff75819cd956a70c07b6 Author: Murtuza Zabuawala Modified Files -

Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop

Thanks, patch applied. On Wed, Apr 15, 2020 at 12:22 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Akshay, > > PFA updated patch. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Mon, Apr 13

Re: pgAdmin 4 - next gettext usage fixes

Thanks, patch applied. On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please find the updated patch. > > On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> I think the fix is incorrect

Re: [pgAdmin4][Patch]: RM 5366 - PgAdmin hangs in 'loading' state after trying to preview the first 100 records

Thanks, patch applied. On Wed, Apr 15, 2020 at 10:32 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #5366 - PgAdmin hangs in ' > loading' state after trying to preview the first 100 records. > > Many users reported this issue but

Re: [pgAdmin4][Patch] - RM 4957 - Constraint Trigger, Deferrable, Deferred option should be disbled if user select EDB-SPL function for trigger for EPAS.

Hi Akshay, Please find the attached updated patch. Thanks, Khushboo On Wed, Apr 15, 2020 at 3:58 PM Akshay Joshi wrote: > Hi Khushboo > > The fix is not correct, as per RM, we should disable Constraint Trigger, > Deferrable, Deferred option when the user selects the "Inline EDB-SPL" > function

Re: pgAdmin 4 - next gettext usage fixes

Hi, next minor gettext and format fixes in patch. Best regards, Libor M. E-mail: libor...@gmail.com GitHub: https://github.com/liborm85 st 15. 4. 2020 v 13:17 odesílatel Akshay Joshi napsal: > > Thanks, patch applied. > > On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal > wrote: >> >> Hi, >>

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

@Dave Page @Akshay Joshi your input please? On Wed, Apr 15, 2020 at 3:13 PM Neel Patel wrote: > Hi, > > I think we should remove the type cast from query during update and > whatever error is thrown should be shown to UI as per scenario 3. > > Thanks, > Neel Patel > > On Wed, Apr 15, 2020 at

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hi Navnath Scenario 3 seems correct to me. No need to type cast. On Wed, Apr 15, 2020 at 6:03 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > @Dave Page @Akshay Joshi > your input please? > > On Wed, Apr 15, 2020 at 3:13 PM Neel Patel > wrote: > >> Hi, >> >> I think we should r

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Removing the typecast will almost certainly lead to other problems. I think we should just remove the length from it. On Wed, Apr 15, 2020 at 1:33 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > @Dave Page @Akshay Joshi > your input please? > > On Wed, Apr 15, 2020 at 3:13 PM Nee

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hello, We are sending the data to backend and depending on errors from backend. Any thoughts on implementation of basic fronted validations? so that we can alert user before it clicks on save button. On Wed, 15 Apr 2020, 18:08 Dave Page, wrote: > Removing the typecast will almost certainly lea

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

On Wed, 15 Apr 2020 at 18:18, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > We are sending the data to backend and depending on errors from backend. Any > thoughts on implementation of basic fronted validations? so that we can > alert user before it clicks on save but

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

On Wed, 15 Apr 2020 at 18:21, Ashesh Vashi wrote: > > > On Wed, 15 Apr 2020 at 18:18, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> We are sending the data to backend and depending on errors from backend. Any >> thoughts on implementation of basic fronted vali

[pgAdmin][RM5400] An unexpected occurred: INTERNAL SERVER ERROR message displayed if database server connected with non super user

Hi Hackers, Attached is the patch to replace the usage of pg_user_mapping table with pg_user_mappings view. pg_user_mapping is not publicly accessible. Changes are done for search objects and foreign data wrappers. pgAdmin throws an exception when accessing User mappings with non privileged users.

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hi Khushboo, Please find the modified patch. I have removed the length from the data types. Test cases also passing on all Postgres versions. Thanks! On Wed, Apr 15, 2020 at 6:22 PM Ashesh Vashi wrote: > > > On Wed, 15 Apr 2020 at 18:21, Ashesh Vashi > wrote: > >> >> >> On Wed, 15 Apr 2020