pgAdmin 4 commit: Make the configuration window in runtime to auto-resi

2020-04-13 Thread Akshay Joshi
Make the configuration window in runtime to auto-resize. Fixes #4864 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c93e93cb47120e652de2bfa539ee24ab32c3337 Author: Neel Patel Modified Files -- docs/en_US/release_notes_4_21.rst |

pgAdmin 4 commit: Added dark mode support for the configuration dialog

2020-04-13 Thread Akshay Joshi
Added dark mode support for the configuration dialog on Windows/macOS runtime. Fixes #4292 Detects dark mode at server start and styles the runtime accordingly. Patch modified by: Neel Patel Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41

pgAdmin 4 commit: Fixed an issue where changing the values of columns w

2020-04-13 Thread Akshay Joshi
Fixed an issue where changing the values of columns with JSONB or JSON types to NULL. Fixes #4969 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b427a8772441eecf24a6932246c5551e7de40614 Author: Aditya Toshniwal Modified Files --

Re: [pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration

2020-04-13 Thread Akshay Joshi
Thanks, patch applied. On Mon, Apr 13, 2020 at 10:48 AM Neel Patel wrote: > Hi, > > Please find an attached patch to fix the issue in the configuration window > in runtime where control where not auto resize and visible when the user > resizes the dialog. > > Do review it and let me know for com

Re: [pgAdmin][RM4969] JSONB and JSON field editing

2020-04-13 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 10, 2020 at 11:49 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch fix issue for jsonb and json field editing. Making > the field blank throws a validation error. The patch will set json, jsonb > to null whe

Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop

2020-04-13 Thread Akshay Joshi
Hi Murtuza The issue has been fixed with your patch, but there is an existing issue discover with the fix. After disconnecting the server and click on Download CSV button confirmation dialog comes and user needs to click twice. Following error observed in the browser: sqleditor.js?ver=42000:1 Unc

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-04-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the test cases due to this patch. Also, this functionality will not be applicable on EPAS server as we can change the view definition without dropping it. Thanks, Khushboo On Wed, Apr 8, 2020 at 11:42 AM Akshay Joshi wrote: > Thanks, patch applied. > >

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

2020-04-13 Thread Akshay Joshi
Hi Navnath Can you please review it? On Mon, Apr 13, 2020 at 2:40 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for running *features tests* using > solenoid(selenium grid + docker). > KIndly review. > To sun feature tests in parallel, requi

[pgAdmin4][Patch]: RM 4445 - Ensure all object names in the title line of the reverse-engineered SQL are *not* quoted.

2020-04-13 Thread Shubham Agarwal
Hi Team, Please find the patch attached for RM-4445. The patch contains following things- 1. Fixes for each node. 2. Fixes for Resql test cases -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company rm_4445_v1.patch Description: Binary data

[pgAdmin RM#1257] Show system XX properties for sequences node

2020-04-13 Thread Vishal Sawale
Hi Hackers, PFA the patch for showing the System sequence properties for sequences node. Please review. Regards, Vishal diff_1257.patch Description: Binary data

[pgAdmin][RM5371] : Tab key navigation is not working in some of the dialogs

2020-04-13 Thread Pradip Parkale
Hi Hackers, Please find the attached path. I have fixed tab key navigation in some of the dialogs. This patch includes the fixes for: 1 Login/Group roles >> Group parameter 2 Table space >> Security >> Privileges 3 Foreign data wrapper >> Security 4 Languages >> Security 5 Foreign table >> colum

[pgAdmin][RM5007] Index should be visible using unique constraints

2020-04-13 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch with below fixes: - Index dropdown should have existing indexes while creating unique constraint - On selecting index from index dropdown, other fields( should be empty and disabled (Applicable for Primary and unique key constraint) - Added test cases Pl

pgAdmin 4 commit: Fixed an issue where the identical packages and seque

2020-04-13 Thread Akshay Joshi
Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. Fixes #5362 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df11f28593e874f6c0b01c63dc272a96528adca9 Modified Files -- docs/en

pgAdmin 4 commit: Fixed an issue where difference SQL is not seen in th

2020-04-13 Thread Akshay Joshi
Fixed an issue where difference SQL is not seen in the schema diff tool for Types. Fixes #5302 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=781b766ac42282a98738fcc658f32fc4e8db74c1 Modified Files -- docs/en_US/release_notes_4_2

pgAdmin 4 commit: Modified some logic for the EPAS server as the user c

2020-04-13 Thread Akshay Joshi
Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=030741bba55ce2420567d46e269099a8a1c53cfb Author: Khushboo Vashi Modified File

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-04-13 Thread Akshay Joshi
Thanks, patch applied. On Mon, Apr 13, 2020 at 2:29 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the test cases due to this patch. > Also, this functionality will not be applicable on EPAS server as we can > change the view definition

[Patch]: Typo in 'test_config.json.in' file

2020-04-13 Thread Neel Patel
Hi, Fix the typo in the test configuration json file while running the test cases. Currently if someone uses the latest file to run the test cases, it will fail to run. Please find the attached patch. Thanks, Neel Patel test_config.patch Description: Binary data

[pgAdmin4][Patch] - RM 5383 - Error related to OID displayed if Click on properties of synonym and Click on refresh button

2020-04-13 Thread Khushboo Vashi
Hi, Please find the attached small patch to fix the RM #5383 - Error related to OID displayed if Click on properties of synonym and Click on refresh button. Thanks, Khushboo RM_5383.patch Description: Binary data