pgAdmin 4 commit: [Accessibility] Use semantic markup to mark emphasize

[Accessibility] Use semantic markup to mark emphasized or special text. Reference: https://www.w3.org/TR/WCAG20-TECHS/H49.html Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=073e310a5a2f05b32a454a9fc6904dd0b12b0ba0 Modified Files ---

pgAdmin 4 commit: Using the 'gettext' as oppose to '_', which is not de

Using the 'gettext' as oppose to '_', which is not defined in the file Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f0847b95dcb9eb73f6027d491e55d2b9e76c70f Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

Hi Khushboo Schema Diff test cases are failing with this patch. Please fix and resend the patch. On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym > properties does not show OID.

pgAdmin 4 commit: Using the 'gettext' as oppose to '_', which is not de

Using the 'gettext' as oppose to '_', which is not defined in these files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a84a62def860cbb11fda2476cf1d1818dfac0f08 Modified Files -- .../browser/server_groups/servers/databases/casts

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym > properties does not show OID. > > As per the current implementation, we completely ignored OID and instead > considered the name

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi wrote: > On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym >> properties does not show OID. >> >> As per the current implementat

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

Hi Khushboo View/MView test also failing with the commit of #5053. Please fix those as well and send a combined patch. On Wed, Apr 8, 2020 at 12:47 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wr

pgAdmin 4 commit: [Domain] Existing expression will expression will alw

[Domain] Existing expression will expression will always result into false Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6c03a6b75db88461efa5064326559e01899f2b4 Modified Files -- .../server_groups/servers/databases/schemas/domai

pgAdmin 4 commit: [COLLATIONS] Do not assign the paramter values, use s

[COLLATIONS] Do not assign the paramter values, use separate variable for new value Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=068b81224559c0b841c84bd6b9e8721979aa5a19 Modified Files -- .../databases/schemas/collations/__init

pgAdmin 4 commit: [Packages] Fixed a typo

[Packages] Fixed a typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7afa30d0ca51e311169aad05da638f44016c91f Modified Files -- .../server_groups/servers/databases/schemas/packages/__init__.py| 2 +- 1 file changed, 1 ins

pgAdmin 4 commit: [Functions] Fixed typos:

[Functions] Fixed typos: - 'gettext' should be used as '_' is not defined - Identical expressions should not be used on both sides of a binary operator. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f21921bb0fbe48aa766c2e4b6847ed15362396 M

pgAdmin 4 commit: [TABLES] Do not assign the paramter values, use separ

[TABLES] Do not assign the paramter values, use separate variable for new value Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b3e1f1e65c32555dcbd788ea880de27053595a6 Modified Files -- .../server_groups/servers/databases/schemas/

pgAdmin 4 commit: [Exclusion Constraint] Fixed an typo - it should have

[Exclusion Constraint] Fixed an typo - it should have been assignment Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c693d158e15287fd391fe2e637a6041978733a2 Modified Files -- .../constraints/exclusion_constraint/static/js/exclusi

pgAdmin 4 commit: [EDB Package Functions] [Functions] Fixed typos:

[EDB Package Functions] [Functions] Fixed typos: - 'gettext' should be used as '_' is not defined - Identical expressions should not be used on both sides of a binary operator. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8fe344c268

pgAdmin 4 commit: [FTS Configuration] Fixed an typo - it should have be

[FTS Configuration] Fixed an typo - it should have been assignment Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29ae6dfbf64f69beea5038ad53b7cd4adea69711 Modified Files -- .../databases/schemas/fts_configurations/static/js/fts_co

pgAdmin 4 commit: [Rules] Removing unnecessary 'if' condition

[Rules] Removing unnecessary 'if' condition Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8fe687eb5505df5ad4fe7bbd37f8aa5f1dea955a Modified Files -- .../servers/databases/schemas/tables/rules/__init__.py | 7 +++ 1

Re: Proposal: Drop support for Internet Explorer

On Tue, Apr 7, 2020 at 1:34 PM richard coleman wrote: > Dave, > > Seeing that IE isn't standards compliant and not only is not being further > developed, but Microsoft is actively discouraging its use, it is probably > time to drop support for it. > > I would caution *against* using browser analy

pgAdmin 4 commit: Various misc fixes:

Various misc fixes: - Using the 'gettext' as oppose to '_', which is not defined - Define missing variables - Fixed escape character in string with double quote - Removed some dead code in a test case - Removed unnecessary self assignment Includes some fixes for Accessibility improvements - Use se

pgAdmin 4 commit: Fixed a typo in previous commit

Fixed a typo in previous commit Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa7ced4ef1eb9e1cb7c9b4505416be36ba681d52 Modified Files -- web/pgadmin/tools/schema_diff/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

pgAdmin 4 commit: Fixed pep8 issue

Fixed pep8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=775e61c248ca2d85c6b992bef337146cb4d0646d Modified Files -- .../server_groups/servers/databases/casts/__init__.py | 15 +++ 1 file changed, 7 insertions

pgAdmin 4 commit: Moved the ip-address check functionality to a separat

Moved the ip-address check functionality to a separate file to improve the maintainability of the code. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a34f61b24209cc4abc1bced1d30ce0ef1cbe57f Modified Files -- .../browser/server_g

pgAdmin 4 commit: Fixed expected output status code, as 410 should be t

Fixed expected output status code, as 410 should be the status code for the object (CAST) not exists in the database server. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a550b569ff5aadb8c2d99cbef4a4233ab00e413 Modified Files --

pgAdmin 4 - next gettext usage fixes

Hello, I fixed next gettext usage: - fixed gettext usage with .format() only for original text with %s - fixed typos - fixed translation yes/no buttons in dialog - improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs t

Re: Proposal: Drop support for Internet Explorer

If its hard to know how many people are actually using Internet Explorer: You could make the next release of pgAdmin display a message occasionally to users of Internet Explorer saying that Internet Explorer will no longer be officially supported in a future version, and when that version comes

Re: RM4292 - Dark mode support for Windows/macOS

Neel, Can you please review/test it? On Wed, Apr 8, 2020 at 9:08 PM Dave Page wrote: > The attached patch detects if dark mode is enabled on Windows (10+)/macOS > (10.14+) at server start, and styles the runtime accordingly. It doesn't > dynamically switch if the user changes their preferences.