pgAdmin 4 commit: Fixed accessibility issue for the missing label from

Fixed accessibility issue for the missing label from the table header. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4036f2a0f2a94047bc3e3b65b2324934baaab43f Author: Vishal Sawale Modified Files -- web/pgadmin/static/js/backform

pgAdmin 4 commit: Ensure that switch cell is in sync with switch contro

Ensure that switch cell is in sync with switch control for accessibility. Fixes #5314 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=37f55ccc25caf51451afd6ee13c5f72a0de11825 Author: Murtuza Zabuawala Modified Files -- docs/en_US

Re: [Accessibility] Parse & validate the web pages

Thanks, patch applied. On Wed, Apr 1, 2020 at 7:00 PM Vishal Sawale wrote: > Hi Hackers, > > Attached is a patch for accessibility issue for table header label > missing. If it is not present, then it will add span for screen reader. > Please review. > > Regards, > Vishal > > > > -- *Thanks &

Re: [pgAdmin4][RM#5314] Make Switch cell sync with Switch control for accessibility

Thanks, patch applied. On Wed, Apr 1, 2020 at 6:58 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > This patch will allow the screen reader software to read the actual value > from Switch cell like Yes/No same as we have for Switch control. > > > -- > Regards, > Murtuza

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Resending the patch. Missed the requirements.txt file in the previous patch. Thanks, Khushboo On Wed, Apr 1, 2020 at 5:38 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch which includes the review comments > given in the review mee

pgAdmin 4 v4.20 released

The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.20. This release of pgAdmin 4 includes over 13 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_20.html. pgAdmin is the leading Open S

pgAdmin 4 commit: Tag REL-4_20 has been created.

Tag REL-4_20 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_20 Log Message --- Tag v4.20

Re: [pgAdmin][RM2172] Search Objects Functionality

Hi Aditya, Review comments: *UI:* 1. When no object is found, the default message should be given, currently no message displayed. 2. Can we have a tooltip on the row "Double click to locate the object in the browser" ? 3. Full stop is missing in the message column objects are disabled in the br

Re: [pgAdmin][RM2172] Search Objects Functionality

Hi Khushboo, Thank you for reviewing. On Thu, Apr 2, 2020 at 4:09 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Aditya, > > Review comments: > > *UI:* > > 1. When no object is found, the default message should be given, currently > no message displayed. > 2. Can we have a too

[pgAdmin][RM5197] Accessibility issues of external packages

Hi Hackers, Attached patch will replace the existing color picker - spectrum-colorpicker with @simonwep/pickr. spectrum-colorpicker has accessibility issues and is not maintained since long. @simonwep/pickr is actively maintained and the package is improving its accessibility actively. Please rev

Re: [pgAdmin][RM2172] Search Objects Functionality

On Thu, Apr 2, 2020 at 4:30 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > Thank you for reviewing. > > > On Thu, Apr 2, 2020 at 4:09 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Aditya, >> >> Review comments: >> >> *UI:* >> >> 1. When n

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Khushboo Following are the initial review comments (GUI): *Desktop Mode: * - KeyError: '_auth_source_manager_obj' in desktop mode. (*Note* error occurs when the patch has applied and server mode is False.) *Server Mode:* AUTHENTICATION_SOURCES = ['internal'] - Try to add a new us

Re: [pgAdmin][RM2172] Search Objects Functionality

Hi Khushboo, On Thu, Apr 2, 2020 at 4:49 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Apr 2, 2020 at 4:30 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> Thank you for reviewing. >> >> >> On Thu, Apr 2, 2020 at 4:09 PM Khushbo

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Akshay, Please find the attached updated patch. On Thu, Apr 2, 2020 at 4:55 PM Akshay Joshi wrote: > Hi Khushboo > > Following are the initial review comments (GUI): > > *Desktop Mode: * > >- KeyError: '_auth_source_manager_obj' in desktop mode. (*Note* error >occurs when the patch h