Hi,
Please find the attached patch to support LDAP Authentication in Server
mode.
To test the patch, config_auth.py needs to be configured for LDAP
configurations. The config settings are explained in this file in detail.
After configuring the parameters, start the pgadmin server in Server mode
an
Hi Khushboo,
I think there is no use of
+if app is not None:
+AuthSourceRegistry.load_auth_sources()
+
in get_auth_sources() function.
On Tue, Mar 17, 2020 at 2:25 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to support
Hi
30 second read of the first version of the patch...
- Please move the configuration into config.py. Users should never have to
modify a distributed file (it messes up packaging). I don't see any reason
to use a different file just for auth config.
- I think all config options should be prefix
Hi Dave,
Thanks for the review.
On Tue, Mar 17, 2020 at 3:42 PM Dave Page wrote:
> Hi
>
> 30 second read of the first version of the patch...
>
> - Please move the configuration into config.py. Users should never have to
> modify a distributed file (it messes up packaging). I don't see any reas
Hi Navnath,
On Tue, Mar 17, 2020 at 3:37 PM navnath gadakh <
navnath.gad...@enterprisedb.com> wrote:
> Hi Khushboo,
>I think there is no use of
>
> +if app is not None:
> +AuthSourceRegistry.load_auth_sources()
> +
>
> in get_auth_sources() function.
>
> Thanks for the review,
Hi
On Tue, Mar 17, 2020 at 10:24 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Dave,
>
> Thanks for the review.
>
> On Tue, Mar 17, 2020 at 3:42 PM Dave Page wrote:
>
>> Hi
>>
>> 30 second read of the first version of the patch...
>>
>> - Please move the configuration into con