Re: Re : [BUG #4943]

2019-12-09 Thread Aditya Toshniwal
++pgadmin-hackers Hi Karan, It is good to know that you're contributing. I would suggest {server name}/{db name} as name instead of did is better for UX. You can get the db name from conn object and server name using the sid (refer - web/pgadmin/browser/server_groups/servers/__init__.py) On Mon

[pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table

2019-12-09 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix an issue where just clicking on an empty textbox like fill factor in tables dialog considers it a change and so the save button is enabled. The fix is common will apply at other places also. Kindly review. -- Thanks and Regards, Aditya Toshniwal Sr. Soft

pgAdmin 4 commit: Added statistics and storage information in reverse e

2019-12-09 Thread Akshay Joshi
Added statistics and storage information in reverse engineering SQL of table/column. Fixes #4982. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f15db03ec38a729b7f591d87e6f8efb314a75b50 Modified Files -- docs/en_US/release_notes_

Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table

2019-12-09 Thread Akshay Joshi
Hi Aditya The issue has not been resolved. Remove fill factor it won't generate MSQL. Please verify and fix it. On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix an issue where just clicking on an > empty te

pgAdmin 4 commit: Fix XSS issue in explain and explain analyze for tabl

2019-12-09 Thread Akshay Joshi
Fix XSS issue in explain and explain analyze for table and type which contain HTML. Fixes #4947. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb26ca0e46e9947977937654e935cb974fd989f1 Author: Khushboo Vashi Modified Files -- do

pgAdmin 4 commit: Update version for release.

2019-12-09 Thread Akshay Joshi
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a87b1387a8d34fe439cbb3d2c82318709f6b512 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files

french translation update

2019-12-09 Thread fred . escallier
Hello for upcoming release Fred messages-fr.tar.xz Description: application/xz-compressed-tar

Re: Re : [BUG #4943]

2019-12-09 Thread Aditya Toshniwal
Hi Karan, Kindly add a hyphen between the message and names, create a patch to pgAdmin hackers(check cc). Kindly also run the test cases and pep8 before sending. On Mon, Dec 9, 2019, 20:17 Karan Takalkar wrote: > I have updated the success message. > Please check the screenshots attached. > Sho

pgAdmin 4 commit: Update French translation.

2019-12-09 Thread Akshay Joshi
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=324722359550443ac51b3daf1e9baba9801ac3f5 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.po| 1275 +--

Re: french translation update

2019-12-09 Thread Akshay Joshi
Thanks, patch applied. On Mon, Dec 9, 2019 at 8:22 PM wrote: > > Hello > for upcoming release > Fred > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin4 v4.16 candidate builds

2019-12-09 Thread Akshay Joshi
Hi All, pgAdmin4 v4.16 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-12-09-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +9

Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table

2019-12-09 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. The modified SQL missed the reset clause for FILLFACTOR. That's added now. I've changed the int/numeric field validation to disallow spaces in the form field. Currently, fill factor allows spaces and fails while saving as "invalid value". Also, added min