Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting

2019-10-09 Thread Akshay Joshi
Hi Aditya I have tried your patch on MAC. Backup job is completed successfully but got the following message: pg_dump: last built-in OID is 16383 pg_dump: no matching schemas were found Please verify it once again and send the modified patch. On Tue, Oct 8, 2019 at 5:46 PM Aditya Toshniwal < adi

Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting

2019-10-09 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. Tested on MacOS, Windows 7, Ubuntu 16 and works fine. Kindly review. On Wed, Oct 9, 2019 at 1:48 PM Akshay Joshi wrote: > Hi Aditya > > I have tried your patch on MAC. Backup job is completed successfully but > got the following message: > pg_dump: las

pgAdmin 4 commit: Optimize Webpack to improve overall performance.

2019-10-09 Thread Akshay Joshi
Optimize Webpack to improve overall performance. Changes include: 1) Remove underscore-string and sprintf-js packages as we were using only %s. Instead, added a function to do the same. Also changed gettext to behave like sprintf directly. 2) backgrid.sizeable.columns was not used anywhere, remo