pgAdmin 4 commit: Don't use Python to get the app details from the Make

2019-09-19 Thread Dave Page
Don't use Python to get the app details from the Makefile. Fixes #4757 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1b0139c9bba85cd88530a7522aeef226b3b0da0 Modified Files -- Makefile | 7 ++- 1 file changed, 6 insertions(+),

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Dave Page
Hi On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow pgAdmin to work behind proxy with its in > built server. I have used werkzeug fixer - > https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Aditya Toshniwal
Hi, On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: > Hi > > On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to allow pgAdmin to work behind proxy with its in >> built server. I have used werkzeug fixer

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Dave Page
On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: > >> Hi >> >> On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attache

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Aditya Toshniwal
On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > > > On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Sep 19, 2019 at 3:28 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Sep 19, 2019 at 6:29 AM Aditya Toshniwal < >>> aditya.t

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Murtuza Zabuawala
Hi, We need to make it configurable, we don't require middleware when we are running in Desktop mode. On Thu, Sep 19, 2019 at 3:52 PM Dave Page wrote: > > > On Thu, Sep 19, 2019 at 11:13 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Sep 19, 2019 at 3:2

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Dave Page
Sure, but is it going to make any real difference? I'd rather have it "just work" if possible. This isn't like compression which we expect to use noticable CPU cycles. On Thu, Sep 19, 2019 at 11:39 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > We need to make it con

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Murtuza Zabuawala
It is small improvement we can do to avoid overhead of checking headers in each HTTP requests for proxies. On Thu, Sep 19, 2019 at 4:12 PM Dave Page wrote: > Sure, but is it going to make any real difference? I'd rather have it > "just work" if possible. > > This isn't like compression which we

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Dave Page
If we can do it automatically at startup based on whether or not the Python code thinks we're running under Desktop mode or not, then I suppose it's a win. That would replace one test per request with one test at startup. It'll still be a minute difference, but every little bit helps I guess. On T

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Aditya Toshniwal
On Thu, Sep 19, 2019 at 4:24 PM Dave Page wrote: > If we can do it automatically at startup based on whether or not the > Python code thinks we're running under Desktop mode or not, then I suppose > it's a win. That would replace one test per request with one test at > startup. It'll still be a m

Re: [pgAdmin][RM4755] pgAdmin does not work behind reverse proxy if in built server is used as it is

2019-09-19 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. The patch will enhance the existing reverse proxy feature using ProxyFix. It is compatible with existing X-Scheme option. Plus, as suggested, the reverse proxy feature will be applied only if SERVER_MODE is True. Kindly review. On Thu, Sep 19, 2019 at 4

[pgAdmin][RM4756] pgAdmin does not load completely if loaded in an iframe

2019-09-19 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to allow pgAdmin to open in iframe. This patch also fixes #4561 (which was rejected :P) where pgAdmin was not working when opened using an html link and not directly. The RM has a sample html file to test things. Kindly review. -- Thanks and Regards, Aditya Tos

Re: pgAdmin4 v4.13 candidate builds

2019-09-19 Thread Fahar Abbas
Hi Akshay, One Round of testing has been done, Can you please publish pgadmin4? Kind Regards, On Tue, Sep 17, 2019 at 1:03 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.13 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-09-17-1/ > > Fahar, can you ple

pgAdmin 4 v4.13 released

2019-09-19 Thread Akshay Joshi
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.13. This release of pgAdmin 4 includes over 46 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_13.html. pgAdmin is the leading Open

pgAdmin 4 commit: Add Reverse Engineered and Modified SQL tests for Uni

2019-09-19 Thread Akshay Joshi
Add Reverse Engineered and Modified SQL tests for Unique Constraints. Fixes #4628 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faa623658035de48bf10820b8664284036ac3269 Modified Files -- docs/en_US/release_notes.rst