Re: Docker build simplification

2019-09-13 Thread Akshay Joshi
Hi Dave I have installed docker, applied your patch and run "*docker build .*". Image has been created without REPOSITORY and TAG is this OK. [image: Screenshot 2019-09-13 at 12.22.57 PM.png] Rest I have tested it works fine. On Wed, Sep 11, 2019 at 4:44 PM Dave Page wrote: > > > On Wed, Sep 1

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-13 Thread Murtuza Zabuawala
Hi, We are making assumption here that all user's service file has port & username inside them. What if they are not present? If I remember correctly those validation were left intentional when we added service field just to make sure that we connect to DB server from pgAdmin4 regardless of those

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-13 Thread Akshay Joshi
Hi Murtuza On Fri, Sep 13, 2019 at 1:40 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > We are making assumption here that all user's service file has port & > username inside them. > What if they are not present? > 5432 is the default port and the system user is

[pgAdmin4][Patch] - RM 4742 - Can not create Primary key with Index & 4624 - RE-SQL/MSQL test cases for Primary Keys

2019-09-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix below RMs. 1. #4742 - Primary Key Dialog: Can not create Primary key with Index 2. #4624 - Add RE-SQL/MSQL test cases for Primary Keys Thanks, Khushboo RM_4624_4742.patch Description: Binary data

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-13 Thread Murtuza Zabuawala
Hi, On Fri, Sep 13, 2019 at 2:32 PM Akshay Joshi wrote: > Hi Murtuza > > On Fri, Sep 13, 2019 at 1:40 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> We are making assumption here that all user's service file has port & >> username inside them. >> What if they

pgAdmin 4 commit: Fix issue where EXEC script doesn't write the complet

2019-09-13 Thread Akshay Joshi
Fix issue where EXEC script doesn't write the complete script for Procedures. Fixes #4727 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5a6df4ddba98fe58e8c08fdbcbf54a1182f0996 Modified Files -- docs/en_US/release_notes_4_13.rst

Re: [pgAdmin4][Patch] - RM 4742 - Can not create Primary key with Index & 4624 - RE-SQL/MSQL test cases for Primary Keys

2019-09-13 Thread Akshay Joshi
Hi Khushboo Following are my review comments: - Test cases failed on every server. - Delete table scenario is missing in check_constraints and index_constraints. - Scenario "Primary Key Constraint with Index" is missing in the 11_plus folder, it is available in the default folder.

pgAdmin 4 commit: Update message catalogs.

2019-09-13 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2acd2a56150fa287b015e2eb431e51171a4f518b Modified Files -- web/pgadmin/messages.pot | 862 +++ .../translations/de/LC_MESSAGES/m

Translators: Release next week

2019-09-13 Thread Akshay Joshi
Hi Translators, We will have a release next week, so updates to translations prior to release would be helpful. The template and catalogs have been updated in git. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-82

Japanese translation (September 2019 - 2)

2019-09-13 Thread fn ln
Hello. Updated translation for upcoming version 4.13 is in attachment. messages.pot was taken from git 2acd2a56. pgadmin4-ja-sep2019-2.7z Description: Binary data