Re: Resql test cases for views and fix for bug: 4650

Hi Usman I have modified the code, please work on the following test cases: - No test case for privileges at all. - We should add alter test cases for check_option, security_barrier and privileges. Attached is the modified patch, please continue your work on it. On Tue, Aug 27, 2019 at

Re: pgAdmin4 Feature Tests intermittent failures fix

Hi Akshay, PFA the patch with fixed review comments. On Thu, Aug 22, 2019 at 4:26 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Yes, I agreed too. > The only thinking was if the test case objective is to check the debugger, > then it should fail instead of skipping it to come i

[pgAdmin][RM4674] User can not launch query tool window if user name contain html characters

Hi Hackers, Attached is the patch to fix the issue. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4674.patch Description: Binary data

pgAdmin 4 commit: Fixed timezone issue in RE-SQL test cases for Roles.

Fixed timezone issue in RE-SQL test cases for Roles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28b741a13a1eeab42e52ba75aca4881e766d8f88 Modified Files -- .../tests/9.4_plus/alter_login_role_options.sql| 2 +- .../roles/te

Re: Resql test cases for views and fix for bug: 4650

Hi, Please find here updated patch with the above required test cases. Please review and commit the changes On Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi wrote: > Hi Usman > > I have modified the code, please work on the following test cases: > >- No test case for privileges at all. >-

pgAdmin 4 commit: Fix query tool launch error if user name contain html

Fix query tool launch error if user name contain html characters. Fixes #4674 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2e5ed937ea686f4d1e9c391a3ab2411cafb Author: Aditya Toshniwal Modified Files -- docs/en_US/release_n

Re: [pgAdmin][RM4674] User can not launch query tool window if user name contain html characters

Thanks patch applied. On Tue, Aug 27, 2019 at 4:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue. > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Co

Re: [pgAdmin][RM4487] Boolean data type is not editable in view data

Thanks patch applied. On Mon, Aug 26, 2019 at 4:23 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix two issues: > 1) 4487 - Boolean data type is not editable in view data > 2) 3778 - No keyboard key to edit boolean column in "View/Edit

pgAdmin 4 commit: 1) Ensure Boolean columns should be editable using ke

1) Ensure Boolean columns should be editable using keyboard keys. Fixes #3778 2) Ensure Boolean columns should be editable in View/Edit data and Query Tool. Fixes #4487 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06ad6b8ba8152639865fa74ed6

[pgAdmin][RM4381] Problem with data editing when using "View/Edit Data" to tables with OID

Hi Hackers, Attached is the patch to fix an issue where, oid column should not be pasted when copy/paste row is used on query output containing the oid column. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant