Re: [GSoC] Ideas for the remaining of the project

Hi On Mon, Jul 15, 2019 at 2:02 AM Yosry Muhammad wrote: > Hi Dave, > > The core patch for this project is being finalized and I am unable to work > for the current few days due to issues mentioned in the previous email. > Therefore, I have been thinking of what can be done in the project after

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Types. Fixes #44

Add Reverse Engineered SQL tests for Types. Fixes #4468 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1dcf46cc5fd72dfb74e39c340398f5e857f8040a Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_11.rst

Re: [RM#4468] Add RE-SQL tests for Type node

Thanks, patch applied. On Mon, Jul 15, 2019 at 7:57 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find patch for RE-SQL type node. > > - Fixed a bug in update.sql which is found during writing tests > - Added logging for JSON file when it fails to load > > > -

[RM#4468] Consistently use ROLE keyword when generating RE-SQL

Hi, Please find attached patch which will change the keyword USER to ROLE when generating RE-SQL. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_4446.diff Description: Binary data

pgAdmin 4 commit: Use ROLE consistently when generating RE-SQL for role

Use ROLE consistently when generating RE-SQL for roles, not USER. Fixes #4446 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1831c9e70af15762cbf812a1e44ce9bc15fe726c Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_

Re: [RM#4468] Consistently use ROLE keyword when generating RE-SQL

Thanks, committed. On Mon, Jul 15, 2019 at 11:11 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find attached patch which will change the keyword USER to ROLE when > generating RE-SQL. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprised

RE-SQL tests patch for FTS parsers node

Hi Team, PFA patch for RE-SQL tests cases for FTS parsers node. -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company resql_fts_parser.patch Description: Binary data

pgAdmin 4 commit: Add Reverse Engineered SQL tests for FTS Parsers. Fix

Add Reverse Engineered SQL tests for FTS Parsers. Fixes #4471 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=809e0682bd0c70c49833ae67e6ffd58ec440d9fe Author: Shubham Agarwal Modified Files -- docs/en_US/release_notes_4_11.rst

Re: RE-SQL tests patch for FTS parsers node

Thanks, applied. On Mon, Jul 15, 2019 at 11:42 AM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > PFA patch for RE-SQL tests cases for FTS parsers node. > > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > -- Dave

[pgAdmin][RM4469] Add RE-SQL test cases for Sequences

Hi Hackers, Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470 ). The fix for it is included in the patch. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer |

Re: [RM#4468] Add RE-SQL tests for Type node

Hi Dave, PFA patch to fix the ACL order so that it RE-SQL tests for type node works consistently on all the platforms. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 15, 2019 at 2:55 PM Dave Page wrote: > Thanks, patch ap

[pgAdmin4][Patch]: RM 4428 and 4448

Hi Hackers, Attached is the patch to fix following issues in pgagent module: - RM 4428 "malformed array literal error when updating pgagent job". - RM 4448 "Error when updating connection string in pgagent Jobs." - When user create a schedule using Create->Schedule dialog browser tree

pgAdmin 4 commit: Stabilise ordering of ACLs in Type RE-SQL tests to pr

Stabilise ordering of ACLs in Type RE-SQL tests to prevent random failures. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4453e33cc28d8ee9e98848b5de6ac41b9444297 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas

Re: [RM#4468] Add RE-SQL tests for Type node

Thanks, applied. On Mon, Jul 15, 2019 at 1:16 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to fix the ACL order so that it RE-SQL tests for type node works > consistently on all the platforms. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http

pgAdmin 4 commit: Fix sequence reverse engineered SQL generation with q

Fix sequence reverse engineered SQL generation with quoted names on PG/EPAS 10+. Fixes #4470 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b82a4ad92f257a623f919e1115e911212dd77ca Author: Aditya Toshniwal Modified Files -- docs

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Sequences. Fixes

Add Reverse Engineered SQL tests for Sequences. Fixes #4469 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3ef1137d9c330b979e92b6d2d8ba1e8ac5d566d Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_11.rst

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

Thanks, committed. On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add RE-SQL test cases for sequences. When running > the test cases, I also found an issue (#4470 >

pgAdmin 4 commit: pgAgent fixes:

pgAgent fixes: "malformed array literal error when updating pgagent job". Fixes #4428 "Error when updating connection string in pgagent Jobs.". Fixes #4448 When user create a schedule using Create->Schedule dialog browser tree is not showing newly created node. Properties tab showing same propert

Re: [pgAdmin4][Patch]: RM 4428 and 4448

Thanks, applied. On Mon, Jul 15, 2019 at 1:32 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix following issues in pgagent module: > >- RM 4428 "malformed array literal error when updating pgagent job". >- RM 4448 "Error when updating connection string in pgagent Job

pgAdmin 4 commit: Cleanup wording.

Cleanup wording. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c2c738f31785b4e0db3007f6499e1fea03f4dac Modified Files -- web/regression/re_sql/tests/test_resql.py | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node

Hi, Please find the attached patch for the RE-SQL and modified SQL tests for check constraint node. For the table child nodes, *create table endpoint *with proper data is required in the JSON file. I have introduced one new parameter named *store_table_id* in the table create endpoint, so the cre