[pgAdmin4][Patch]: RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section

Hi Hackers, Attached is the patch to fix RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section. Added regression test cases for delete multiple pgAgent Job, multiple schedules and multiple steps. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architec

pgAdmin 4 commit: Fix some minor UI issues on IE11. Fixes #4462

Fix some minor UI issues on IE11. Fixes #4462 Includes some Jasmine test case fixes from Ganesh. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=20a5899c7d4192d0ffb695366f3db3a090de0610 Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

Thanks - committed as the IE fixes, with the Jasmine stuff as a bonus :-) On Thu, Jul 11, 2019 at 7:40 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch for jasmine tests fix. Patch also includes > fixes for edit/delete cell focus on IE by M

pgAdmin 4 commit: Fix an error that could be seen when editing column p

Fix an error that could be seen when editing column privileges. Fixes #4389 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed01274f7b95caeba4943d550792abf265fea7f8 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_4

Re: [GSoC] Finalized First Patch

On Fri, Jul 12, 2019 at 5:57 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Yosry, > > On Thu, Jul 11, 2019 at 6:50 PM Yosry Muhammad wrote: > >> Hi Khushboo, >> Please find an updated patch attached with the mentioned import line >> removed. >> >> Looks good to me. > >> On Thu,

pgAdmin 4 commit: Fix dropping of pgAgent schedules through the Job pro

Fix dropping of pgAgent schedules through the Job properties. Fixes #3996 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29fd83dc6c5ee5c00d1b1f89261b23195878a2cc Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_4_1

[pgAdmin4][Patch] : RE-SQL tests for Collation node

Hi, Please find the attached patch for the RE-SQL tests for collation node. This patch also includes the *modified SQL tests* as well as fixes for the RE-SQL in the collation node which I found while implementing this. To add the modified SQL tests, 2 optional parameters are introduced in the JSO

Re: [GSoC] Finalized First Patch

I will look into it and get back to you. Thanks ! On Fri, Jul 12, 2019, 11:20 AM Dave Page wrote: > > > On Fri, Jul 12, 2019 at 5:57 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> On Thu, Jul 11, 2019 at 6:50 PM Yosry Muhammad >> wrote: >> >>> Hi Khushboo, >>

Re: [pgAdmin4][Patch]: RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section

Thanks, applied. On Fri, Jul 12, 2019 at 9:29 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM 3996 "Error dropping Schedule" message > displayed if drop schedule through property section. Added regression test > cases for delete multiple pgAgent Job, multiple schedules a

pgAdmin 4 commit: Fix wording.

Fix wording. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3dd1e8e10216243b05b205e6769eabbdce0c13cd Modified Files -- .../maintenance/tests/test_maintenance_create_job_unit_test.py | 6 +++--- 1 file changed, 3 insertions(+),

Re: RE-SQL tests patch for packages node

Hi Dave, Please find the modified patch for packages as test cases were failing on some servers. Thanks! On Thu, Jul 11, 2019 at 1:53 PM Dave Page wrote: > Thanks, applied. > > On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Navnath >> >> I h

Re: RE-SQL tests patch for packages node

Thanks, applied. On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the modified patch for packages as test cases were > failing on some servers. > Thanks! > > > On Thu, Jul 11, 2019 at 1:53 PM Dave Page > wrote: > >> Thanks,

pgAdmin 4 commit: Fix re-sql tests for packages on EPAS 9.4-9.6.

Fix re-sql tests for packages on EPAS 9.4-9.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce8a2bb2664dd30ba2f7629d185b4047883c5627 Author: Navnath Gadakh Modified Files -- .../tests/ppas/10_plus/alter_package_headers_and_comm

Re: [pgAdmin4][Patch] : RE-SQL tests for Collation node

Hi On Fri, Jul 12, 2019 at 10:46 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for the RE-SQL tests for collation node. > This patch also includes the *modified SQL tests* as well as fixes for > the RE-SQL in the collation node which I found

Re: [pgAdmin4][Patch] : RE-SQL tests for Collation node

Hi Dave, Please find the attached updated patch. On Fri, Jul 12, 2019 at 4:07 PM Dave Page wrote: > Hi > > On Fri, Jul 12, 2019 at 10:46 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for the RE-SQL tests for collation node. >> This p

RM 4463 - RESQL test cases for domain node

Hi, Please find attached patch for reverse engineering test cases for domain node ( RM #4463 ) Do review it and let me know for comments. Thanks, Neel Patel RM_4463.patch Description: Binary data

pgAdmin 4 commit: Rename horribly named function.

Rename horribly named function. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4d5a687b95915892d925aa81a0f86a116be64c Modified Files -- web/pgadmin/tools/backup/__init__.py| 6 +++--- web/pgadmin/t

pgAdmin 4 commit: Fix external utility tests to run on Windows

Fix external utility tests to run on Windows Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b5ca0771573de12db660addb73400a2d0794c4f Modified Files -- web/pgadmin/tools/backup/tests/test_backup_create_job_unit_test.py| 4

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Collations. Fixe

Add Reverse Engineered SQL tests for Collations. Fixes #4464 This also adds the ability to test the msql output in ALTER steps. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e6f4c0082d0a20b89138ee50f435d00defeec9 Author: Khushboo Vashi M

Re: [pgAdmin4][Patch] : RE-SQL tests for Collation node

Thanks, applied. On Fri, Jul 12, 2019 at 11:54 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch. > > On Fri, Jul 12, 2019 at 4:07 PM Dave Page wrote: > >> Hi >> >> On Fri, Jul 12, 2019 at 10:46 AM Khushboo Vashi < >> khushboo.va...

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Domains. Fixes #

Add Reverse Engineered SQL tests for Domains. Fixes #4463 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88ab6db9769023485354e967f9f0f7288df5b1fb Author: Neel Patel Modified Files -- docs/en_US/release_notes_4_11.rst

Re: RM 4463 - RESQL test cases for domain node

Thanks, applied. On Fri, Jul 12, 2019 at 12:31 PM Neel Patel wrote: > Hi, > > Please find attached patch for reverse engineering test cases for domain > node ( RM #4463 ) > Do review it and let me know for comments. > > Thanks, > Neel Patel > -- Dave Page Blog: http://pgsnake.blogspot.com Twi