Re: RE-SQL tests patch for packages node

Hi Navnath I have tested the patch and it is not working for EPAS 9.4, 9.5 and 9.6. Attached is the modified patch which fix the issue. Please work on child node (functions, procedure and variables) of Packages on top of modified patch. On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh < navnath.gad

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

Hi Dave, Ticket number 3919 refers to keyboard accessibility issues for sub-node control and back grid but this patch covers only sub-node control. Should I create new one? I have added the screenshot having newly added shortcut and updated keyboard shortcut rst file. Also moved the code changes f

Updated patch for RM #4453

Hi, PFA, updated patch for RM #4453 Thanks, Nagesh extension_resql_tests_v5.patch Description: Binary data

Re: RE-SQL test patch for extension node

Please ignore this patch. Sending updated on new thread On Thu, Jul 11, 2019 at 11:40 AM Nagesh Dhope wrote: > Fixed failing extension resql test cases on PG 9.4 and PG 9.5. > PFA updated patch. > > On Tue, Jul 9, 2019 at 5:53 PM Dave Page wrote: > >> Thanks, applied! >> >> On Tue, Jul 9, 2019

pgAdmin 4 commit: Fixed resql test cases for Extensions specific to dat

Fixed resql test cases for Extensions specific to database servers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6c067025cfe6ecff786efe3b671c8c7dd840c17 Author: Nagesh Dhope Modified Files -- .../tests/9.4_plus/alter_extension

Re: Updated patch for RM #4453

Thanks patch applied. But we still need to modify the logic to check extension with exact version is available on database servers. On Thu, Jul 11, 2019 at 12:58 PM Nagesh Dhope wrote: > Hi, > PFA, updated patch for RM #4453 > > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. So

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Languages. Fixes

Add Reverse Engineered SQL tests for Languages. Fixes #4452 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cdf655f7db23335132e432bdda46e8b2dfb0303d Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_4_11.rst

Re: [pgAdmin4][Patch]: RM 4452 Add RE-SQL tests for Languages

Thanks, applied. On Wed, Jul 10, 2019 at 11:28 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4452 "Add RE-SQL tests for Languages". > > Please review it. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private L

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Packages. Fixes

Add Reverse Engineered SQL tests for Packages. Fixes #4456 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28585110dd6acb95ab3bbc9aafbb57cdef3b17a9 Author: Navnath Gadakh Modified Files -- docs/en_US/release_notes_4_11.rst

Re: RE-SQL tests patch for packages node

Thanks, applied. On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi wrote: > Hi Navnath > > I have tested the patch and it is not working for EPAS 9.4, 9.5 and 9.6. > Attached is the modified patch which fix the issue. > Please work on child node (functions, procedure and variables) of Packages > on t

pgAdmin 4 commit: Allow keyboard navigation of all controls on subnode

Allow keyboard navigation of all controls on subnode grids. Partially fixes #3919 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4cbc1f2f59192f6461cfeea96aec2d3ee5df5f06 Author: Ganesh Jaybhay Modified Files -- docs/en_US/keyboa

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

Thanks - patch applied with some doc tweaks. No need for a new ticket! On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Dave, > > Ticket number 3919 refers to keyboard accessibility issues for sub-node > control and back grid but this patch covers onl

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

Hi Ganesh, It looks like this has broken the Jasmine tests (which I admit I forgot to run before committing). Can you fix ASAP please? Thanks. On Thu, Jul 11, 2019 at 10:14 AM Dave Page wrote: > Thanks - patch applied with some doc tweaks. > > No need for a new ticket! > > On Thu, Jul 11, 2019

patch for RE-SQL test cases for FTS Dictionaries.

Hi Hackers, PFA, patch for RE-SQL test cases for FTS Dictionaries. -- Thanks, Nagesh fts_dictionaries_resql_v1.patch Description: Binary data

pgAdmin 4 commit: Add Reverse Engineered SQL tests for FTS Dictionaries

Add Reverse Engineered SQL tests for FTS Dictionaries. Fixes #4460 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=379b92729a280623e3b2c186d7395694502898f2 Author: Nagesh Dhope Modified Files -- docs/en_US/release_notes_4_11.rst

Re: patch for RE-SQL test cases for FTS Dictionaries.

Thanks, commited. On Thu, Jul 11, 2019 at 1:18 PM Nagesh Dhope wrote: > Hi Hackers, > > PFA, patch for RE-SQL test cases for FTS Dictionaries. > > -- > Thanks, > Nagesh > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterpr

pgAdmin 4 commit: Make the RE-SQL test output a little more consistent

Make the RE-SQL test output a little more consistent with other tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1df26cb731e2f9b42d2e83def3e25f0cab0cd607 Modified Files -- web/regression/re_sql/tests/test_resql.py | 17 ++

Re: [GSoC] Finalized First Patch

Hi Khushboo, Please find an updated patch attached with the mentioned import line removed. On Thu, Jul 11, 2019 at 6:45 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad wrote: > >> Hi, >> >> On Wed, Jul 10, 2019, 9:14 AM Khushbo

[pgAdmin4][Patch]: RM 4389 "string indices must be integers" error displayed if select Privileges for Columns

Hi Hackers, Attached is the patch to fix RM 4389 "string indices must be integers" error displayed if select Privileges for Columns. Added API test case for the scenario. Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limite

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

Hi Dave, Please find the attached patch for jasmine tests fix. Patch also includes fixes for edit/delete cell focus on IE by Murtuza. Regards, Ganesh Jaybhay On Thu, Jul 11, 2019 at 3:49 PM Dave Page wrote: > Hi Ganesh, > > It looks like this has broken the Jasmine tests (which I admit I forg