pgAdmin 4 commit: Modified the creation logic of custom schema and adde

2019-07-09 Thread Akshay Joshi
Modified the creation logic of custom schema and added support for schema id in re_sql test framework. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4ac1e804e1b943a2ef8db71c06fb7b982096585 Author: Khushboo Vashi Modified Files ---

pgAdmin 4 commit: 1) Ensure re_sql tests should not abort at the first

2019-07-09 Thread Akshay Joshi
1) Ensure re_sql tests should not abort at the first failure, it should run all the test cases. 2) Added place holder for owner, so we won't need to create separate pg/ppas folder just because of change in the owner name. Branch -- master Details --- https://git.postgresql.org/gitweb?p=

pgAdmin 4 commit: Remove some files which was committed by mistake.

2019-07-09 Thread Akshay Joshi
Remove some files which was committed by mistake. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f085460453abaae2f0fcdc5ef0adc16e92d00f77 Modified Files -- .../tests/9.3_plus/create_trusted_language.sql | 11 -- .../tests/9

Re: RE-SQL test patch for extension node

2019-07-09 Thread Dave Page
Hi I have a sneaking suspicion that the work Akshay and Khushboo have been doing might have broken this :-( Create Extension with all options..OK ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 140024

Re: RE-SQL test patch for extension node

2019-07-09 Thread Dave Page
Thanks, applied! On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope wrote: > Hi Dave, > > On Tue, Jul 9, 2019 at 4:54 PM Dave Page wrote: > >> Hi >> >> I have a sneaking suspicion that the work Akshay and Khushboo have been >> doing might have broken this :-( >> > > Yup, earlier we were able to create

pgAdmin 4 commit: Add RE-SQL tests for Extensions. Fixes #4453

2019-07-09 Thread Dave Page
Add RE-SQL tests for Extensions. Fixes #4453 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=84b712a0082eb141c08f34a3836f33cdd35b8d06 Author: Nagesh Dhope Modified Files -- docs/en_US/release_notes_4_11.rst | 1 +

pgAdmin 4 commit: Fix typo

2019-07-09 Thread Dave Page
Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a56e47c5ce467863632036cd9cad7f9476306e5 Modified Files -- docs/en_US/server_deployment.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Add an example Traefik configuration.

2019-07-09 Thread Dave Page
Add an example Traefik configuration. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf0d53bc2cb9dca30277f421debd03a42914aa9d Modified Files -- docs/en_US/container_deployment.rst | 33 - 1 file chan

Re: RE-SQL test patch for extension node

2019-07-09 Thread Nagesh Dhope
Hi Dave, Please find updated patch with *sslinfo.* On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: > Hi > > On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope > wrote: > >> Hi Hackers, >> Please review attached patch for RE-SQL test cases for *extension* node. >> > > Unfortunately this fails on Postg

[pgAdmin4][patch] Reverse engineering sql test cases for FTS configuration

2019-07-09 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch for reverse engineering sql test cases of FTS configuration. Kindly review. Regards, Ganesh Jaybhay re_sql_fts_configuration.patch Description: Binary data

Re: RE-SQL test patch for extension node

2019-07-09 Thread Nagesh Dhope
Hi Dave, On Tue, Jul 9, 2019 at 4:54 PM Dave Page wrote: > Hi > > I have a sneaking suspicion that the work Akshay and Khushboo have been > doing might have broken this :-( > Yup, earlier we were able to create a schema if not exists while running *alter *test cases. As this capability is remo

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

2019-07-09 Thread Dave Page
Hi, What's the ticket number for this? That's a fair amount of code for a one-line description. There are also no doc changes describing how to navigate the sub-node control that I can see. Also; instead of changing the repo used for backgrid, can we not un-vendorise it? On Mon, Jul 8, 2019 at 4

pgAdmin 4 commit: Add Reverse Engineered SQL tests for FTS Configuratio

2019-07-09 Thread Dave Page
Add Reverse Engineered SQL tests for FTS Configurations. Fixes #4454 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7d6966d603eab805ea6cbc76bf1a28766a3c412 Author: Ganesh Jaybhay Modified Files -- docs/en_US/release_notes_4_11.r

Re: [pgAdmin4][patch] Reverse engineering sql test cases for FTS configuration

2019-07-09 Thread Dave Page
Thanks, committed. On Tue, Jul 9, 2019 at 2:29 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for reverse engineering sql test cases of > FTS configuration. > Kindly review. > > Regards, > Ganesh Jaybhay > -- Dave Page Blog: http://

Re: [GSoC] Finalized First Patch

2019-07-09 Thread Khushboo Vashi
Hi Yosry, I liked the way you have refactored the code at some places in the JS file and made it cleaner. Here are some points: 1. The table (including partition table) with a single column having that column primary key is editable but the save button is disabled, so, ultimately I can't save the