[pgAdmin][RM4404] Feature tests

2019-07-03 Thread Aditya Toshniwal
Hi Hackers, I have added GUI test case for testing string primary keys. Also, refactored existing code to reuse code snippets. Tested on Chrome and Firefox. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a T

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Akshay Joshi
Hi Murtuza I have tested the patch and I think below string should be modified: Server(Type: #ppas) is not supported for the Resource Groups module - Skipped Server version(12) is not supported for the Resource Groups module - Skipped It misleads, that server type 'ppas' is not supported for

[pgAdmin][RM4318] Change CSS cursors to reflect locked layout level

2019-07-03 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to update wcDocker to latest version where the fix for changing CSS cursors when layout is locked is merged. Do not forget to yarn install before bundle. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Dave Page
Hi On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi wrote: > Hi Murtuza > > I have tested the patch and I think below string should be modified: > Server(Type: #ppas) is not supported for the Resource Groups module - > Skipped > Server version(12) is not supported for the Resource Groups module -

[pgAdmin][RM4429] Drag and Drop name in query tool is not working for Firefox browser

2019-07-03 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix drag and drop issue on firefox. Had to make few code changes required by firefox explicitly :/ Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4429.patch D

pgAdmin 4 commit: Add EXPLAIN options for SETTINGS and SUMMARY. Fixes #

2019-07-03 Thread Dave Page
Add EXPLAIN options for SETTINGS and SUMMARY. Fixes #4335 Prevent flickering of large tooltips on the Graphical EXPLAIN canvas. Fixes #4224 EXPLAIN options should be Query Tool instance-specific. Fixes #4395 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=

Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-07-03 Thread Dave Page
Thanks, applied. On Tue, Jul 2, 2019 at 8:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The SUMMARY data will be visible on hover > over the top-right icon along JIT stats and Triggers (if any). > I'm not sure where does SETTIN

pgAdmin 4 commit: Add more comprehensive feature tests for the data gri

2019-07-03 Thread Dave Page
Add more comprehensive feature tests for the data grid editor. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4bc4475cda632ffe1ac912b9f42af18d7d8af48 Author: Aditya Toshniwal Modified Files -- web/pgadmin/feature_tests/locators.

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Murtuza Zabuawala
Hi, PFA updated patch with corrections in the print messages. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 3, 2019 at 5:36 PM Dave Page wrote: > Hi > > On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi > wrote: > >> Hi Murtu

Re: [pgAdmin][RM4404] Feature tests

2019-07-03 Thread Dave Page
Thanks, applied. On Wed, Jul 3, 2019 at 8:26 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I have added GUI test case for testing string primary keys. Also, > refactored existing code to reuse code snippets. > Tested on Chrome and Firefox. > > Kindly review. >

pgAdmin 4 commit: Add RE-SQL tests for Roles and Resource Groups. Fixes

2019-07-03 Thread Dave Page
Add RE-SQL tests for Roles and Resource Groups. Fixes #4415 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=588e3814d157c6af75092876ebbf05f386ccf16b Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_11.rst

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Dave Page
Thanks, applied. On Wed, Jul 3, 2019 at 2:30 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch with corrections in the print messages. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company