pgAdmin 4 commit: Allow editing of data where a primary key column incl

2019-06-20 Thread Dave Page
Allow editing of data where a primary key column includes a % sign in the value. Fixes #4036 Fix an XSS issue seen in View/Edit data mode if a column name includes HTML. Fixes #4367 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e8ebbd375f8

[pgAdmin4][Patch] - RM 4380 - Table properties dialog - can not edit columns and partitions at the same time

2019-06-20 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4380 - Table properties dialog - can not edit columns and partitions at the same time. Thanks, Khushboo RM_4380.patch Description: Binary data

pgAdmin 4 commit: Fix formatting change which inadvertently broke the f

2019-06-20 Thread Dave Page
Fix formatting change which inadvertently broke the feature tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb4afce6296741da20d13d9ed7172b147f031834 Modified Files -- web/pgadmin/static/js/sqleditor/history/query_history_det

pgAdmin 4 commit: Remove additional "SETOF" included when generating CR

2019-06-20 Thread Dave Page
Remove additional "SETOF" included when generating CREATE scripts for trigger functions. Fixes #4362 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81752bb9984765ae1621806311e3db52adea0dad Modified Files -- docs/en_US/release_not

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-20 Thread Dave Page
Thanks, applied. On Thu, Jun 20, 2019 at 7:48 AM Akshay Joshi wrote: > Hi Dave > > On Wed, Jun 19, 2019 at 8:47 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: >> >>> Hi >>> >>> On Wed, Jun 19, 2019 at 9:55 AM Akshay Jos

pgAdmin 4 commit: Fix regression tests.

2019-06-20 Thread Dave Page
Fix regression tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=78d55c7cc0a5ac1f7783fbc4f086421900192f16 Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/sqleditor/tests/test_view_data_templates.py | 5 + 1 fi

pgAdmin 4 commit: Ensure that both columns and partitions can be edited

2019-06-20 Thread Dave Page
Ensure that both columns and partitions can be edited at the same time in the table dialog. Fixes #4380 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c07e52b9de6ed53b9f43be7ab12092596e12ea05 Author: Khushboo Vashi Modified Files --

Re: [pgAdmin4][Patch] - RM 4380 - Table properties dialog - can not edit columns and partitions at the same time

2019-06-20 Thread Dave Page
Thanks, applied. On Thu, Jun 20, 2019 at 12:25 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #4380 - Table properties > dialog - can not edit columns and partitions at the same time. > > Thanks, > Khushboo > > > > -- Dave Page

pgAdmin 4 commit: Fix regression tests.

2019-06-20 Thread Dave Page
Fix regression tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9dbb74367d277099eedd605b8d6e9f84cd9382f2 Modified Files -- web/regression/javascript/history/query_history_spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 de

pgAdmin 4 commit: PEP-8 fixes.

2019-06-20 Thread Dave Page
PEP-8 fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=644624eabe3661d429efccc123d070815a040fae Modified Files -- .../server_groups/servers/databases/schemas/tables/utils.py | 12 +++- 1 file changed, 7 insertions(+),

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-20 Thread Yosry Muhammad
On Thu, Jun 20, 2019 at 7:49 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > [forked the mail chain for code review] > Hi Yosry, > > On Wed, Jun 19, 2019 at 5:24 PM Dave Page wrote: > >> >> Aditya; can you do a quick code review please? Bear in mind it's a work >> in progress an

change to Docker entrypoint.sh

2019-06-20 Thread Andrew Coleman
Hi All! I am new to this, so I apologize beforehand if it's not entirely kosher, but I have a proposed change to the Dockerfile entrypoint.sh to allow for configurable servers.json filename path. The reasoning behind this is that I have a Kubernetes deployment of pgadmin where I build a ConfigMap