Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

Hi, This is not working on Python 2.7 :( Attached patch will add an __init__ file in the utils directory under debugger to make it work with python 2.7 On Fri, Jun 14, 2019 at 5:17 PM Dave Page wrote: > Thanks, applied. > > On Fri, Jun 14, 2019 at 10:38 AM Aditya Toshniwal < > aditya.toshni...

pgAdmin 4 commit: Added missing __init__.py file in debugger utils whic

Added missing __init__.py file in debugger utils which is required for Python 2.7 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce7679c4bd493c8972ea72d3575e8f47c0b10c8c Author: Aditya Toshniwal Modified Files -- web/pgadmin/too

Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

Thanks patch applied. On Wed, Jun 19, 2019 at 12:35 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > This is not working on Python 2.7 :( > Attached patch will add an __init__ file in the utils directory under > debugger to make it work with python 2.7 > > > On Fri, Jun 1

[pgAdmin4][Patch]: RM #4362 trigger function create script

Hi Hackers, Attached is the patch to fix RM #4362 trigger function create script. Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4362.patch Description: Binary data

pgAdmin 4 commit: Capitalize the word 'export' used in Import/Export mo

Capitalize the word 'export' used in Import/Export module. Fixes #4345 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c0ea0c012839d69f9b40f3efcc632a5c4d52cff Modified Files -- docs/en_US/release_notes_4_9.rst

Re: [GSoC][Patch] Automatic Mode Detection V1

Hi On Wed, Jun 19, 2019 at 6:18 AM Yosry Muhammad wrote: > > Waiting for the icon, will set it up once it is ready. > It's underway :-) > I ran pep8 checks and JS tests on this patch, however I could not run > python tests due to a problem with chromedriver (working on it), please let > me kn

Re: [GSoC][Patch] Automatic Mode Detection V1

Hi, On Wed, Jun 19, 2019, 1:54 PM Dave Page wrote: . - We need to add a "do you want to continue" warning before actions like Execute or EXPLAIN are run, if there are unsaved changes in the grid. - I think we should make the text in any cells that has been edited bold until saved, so the user

Re: [GSoC][Patch] Automatic Mode Detection V1

Hi On Wed, Jun 19, 2019 at 2:47 PM Yosry Muhammad wrote: > Hi, > > > On Wed, Jun 19, 2019, 1:54 PM Dave Page wrote: > . > > - We need to add a "do you want to continue" warning before actions like > Execute or EXPLAIN are run, if there are unsaved changes in the grid. > > - I think we should ma

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

Hi On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4362 trigger function create script. > Please review it. > While I can see how this works, I question why we have the string "SETOF" in prorettypname anyway? That's a separate property, so

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

Hi Dave On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: > Hi > > On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #4362 trigger function create script. >> Please review it. >> > > While I can see how this

Re: [GSoC][Patch] Automatic Mode Detection V1

Hi there ! On Wed, Jun 19, 2019 at 4:11 PM Dave Page wrote: > >> - We need to think about how data editing fits in with transaction >> control. Right now, it seems to happen entirely outside of it - for >> example, I tend to work with auto commit turned off, so my connection sits >> idle-in-tran

Re: [GSoC][Patch] Automatic Mode Detection V1

On Thu, Jun 20, 2019 at 2:20 AM Yosry Muhammad wrote: > Hi there ! > > On Wed, Jun 19, 2019 at 4:11 PM Dave Page wrote: > >> >>> - We need to think about how data editing fits in with transaction >>> control. Right now, it seems to happen entirely outside of it - for >>> example, I tend to work

Re: [GSoC][Patch] Automatic Mode Detection V1

[forked the mail chain for code review] Hi Yosry, On Wed, Jun 19, 2019 at 5:24 PM Dave Page wrote: > Hi > > On Wed, Jun 19, 2019 at 6:18 AM Yosry Muhammad wrote: > >> >> Waiting for the icon, will set it up once it is ready. >> > > It's underway :-) > > >> I ran pep8 checks and JS tests on this

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

Hi Dave On Wed, Jun 19, 2019 at 8:47 PM Akshay Joshi wrote: > Hi Dave > > On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: > >> Hi >> >> On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix RM #4362 trigger