[pgAdmin4][Patch]: RM 4360 Debugger buttons should be disabled until it is completely started

2019-06-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #4360 Debugger buttons should be disabled until it is completely started. Patch contains following fix apart from the actual RM: - Fixed issue when restart the execution of debugger, it is a regression of #4329 - Fixed issue while change in pre

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-18 Thread Dave Page
Hi [please keep the maililng list CC'd] On Mon, Jun 17, 2019 at 3:05 PM Yosry Muhammad wrote: > >> Do you want me to ask our design guy for an icon? >> > > That would be great to keep things clear and separated for the users. > I've asked Chethana (CC'd) to create one. > Please find attached

pgAdmin 4 commit: Add a framework for testing reversed engineered SQL a

2019-06-18 Thread Dave Page
Add a framework for testing reversed engineered SQL and CRUD API endpoints. Fixes #4202 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e65c971a35620afd1354e9ff7e049b2dcb705b2 Author: Akshay Joshi Modified Files -- Makefile

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-18 Thread Dave Page
Thanks - applied! On Tue, Jun 18, 2019 at 7:04 AM Akshay Joshi wrote: > Hi Dave/Hackers > > Attached is the modified patch to fix the given review comments. Please > review it. > > On Mon, Jun 17, 2019 at 2:29 PM Dave Page wrote: > >> >> >> On Mon, Jun 17, 2019 at 9:41 AM Akshay Joshi < >> aksh

pgAdmin 4 commit: Ensure the debugger control buttons are only enabled

2019-06-18 Thread Dave Page
Ensure the debugger control buttons are only enabled once initialisation is complete. Fixes #4360 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b36d5d153bb77141b5f40634c2ea2a03601acaab Author: Akshay Joshi Modified Files -- doc

Re: [pgAdmin4][Patch]: RM 4360 Debugger buttons should be disabled until it is completely started

2019-06-18 Thread Dave Page
Thanks, patch applied. On Tue, Jun 18, 2019 at 9:52 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4360 Debugger buttons should be disabled > until it is completely started. Patch contains following fix apart from the > actual RM: > >- Fixed issue when restart the

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-18 Thread Yosry Muhammad
Hi, I have been working all day to try to make this patch applicable. On Tue, Jun 18, 2019 at 3:05 PM Dave Page wrote: > Hi > > [please keep the maililng list CC'd] > > On Mon, Jun 17, 2019 at 3:05 PM Yosry Muhammad wrote: > >> >>> Do you want me to ask our design guy for an icon? >>> >> >> Tha