Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-16 Thread Yosry Muhammad
This is a patch fixing a problem with the above patch that happened when: - primary key columns are renamed. - other columns are renamed to be like primary key columns. This problem happened mainly because the primary keys are identified in the front-end by their names. This can be handled in a be

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-16 Thread Akshay Joshi
Hi Dave/Hackers On Fri, Jun 14, 2019 at 6:10 PM Akshay Joshi wrote: > > > On Fri, Jun 14, 2019 at 1:59 PM Dave Page wrote: > >> Hi >> >> On Thu, Jun 13, 2019 at 12:52 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers >>> >>> I have implemented the new test framework t

[pgAdmin][RM3174] Distinguish simple tables from tables that are inherited and from which other tables are inherited

2019-06-16 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to change icons for table inheritance (icons by Chethana Kumar) Along with this, I have also fixed few other issues/icons found on the way: 1) Dependencies tab for inherited tables/foreign keys shows partial text (#3994). 2) Dependencies tab for child partition ta