pgAdmin 4 commit: Ensure strings are properly encoded in the Query Hist

2019-06-14 Thread Dave Page
Ensure strings are properly encoded in the Query History. Fixes #4349 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b69f92d70f4ec9a2f1624238d92c2af7a792f2d Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_9

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-14 Thread Dave Page
Hi On Thu, Jun 13, 2019 at 12:52 PM Akshay Joshi wrote: > Hi Hackers > > I have implemented the new test framework to test the Reverse Engineering > SQL. I have integrated it as a part of API/Regression test suite. It will > work when we run all the test cases or module wise test case. > > *How

Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

2019-06-14 Thread Aditya Toshniwal
Hi Hackers, I have missed a line while implementing this. Attached is the patch to fix that. Although it has not caused any trouble, but still it should be changed. Kindly review. On Mon, Jun 10, 2019 at 7:28 PM Dave Page wrote: > Thanks, patch applied. > > On Mon, Jun 10, 2019 at 1:58 PM Adity

pgAdmin 4 commit: Add minor change missed in previous commit. Fixes #43

2019-06-14 Thread Dave Page
Add minor change missed in previous commit. Fixes #4329 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2894c6cd14a16016ed74bfa028dfa09f95917bf9 Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/debugger/__init__.py | 2

Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

2019-06-14 Thread Dave Page
Thanks, applied. On Fri, Jun 14, 2019 at 10:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I have missed a line while implementing this. Attached is the patch to fix > that. > Although it has not caused any trouble, but still it should be changed. > Kindly re

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-14 Thread Akshay Joshi
On Fri, Jun 14, 2019 at 1:59 PM Dave Page wrote: > Hi > > On Thu, Jun 13, 2019 at 12:52 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers >> >> I have implemented the new test framework to test the Reverse Engineering >> SQL. I have integrated it as a part of API/Regressio

usability issues

2019-06-14 Thread Phil Sevenants
I'm new to pgAdmin and giving it a chance to show it's utility to me. A response into the following bug/user issues will help keep me as a user: 1. Loss of to cycle through windows of queries (I develop bunches of queries). I'll have to try having each query in a separate browser giving

[GSoC][Patch] Automatic Mode Detection V1

2019-06-14 Thread Yosry Muhammad
Dear all, This is my first patch of my GSoC project, query tool automatic mode detection. In this patch, the initial (basic) version of the project is implemented. In this version, query resultsets are updatable if and only if: - All the columns belong to a single table - No duplicate columns are