Minor patch to fix reggression of select2 option

2019-04-30 Thread Neel Patel
Hi Team, Please find attached patch to fix the issue where we should properly assigned 'dropdownParent' select2 options. This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717 Do review it and let us know for comments. Thanks, Neel Patel select2_options.patch Description: Bin

pgAdmin4 v4.6 candidate builds

2019-04-30 Thread Akshay Joshi
Hi All, pgAdmin4 v4.6 candidate builds and source can be found at https://developer. pgadmin.org/builds/2019-04-30-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +9

Re: pgAdmin4 v4.6 candidate builds

2019-04-30 Thread Fahar Abbas
Hi Akshay! Thanks for sharing pgAdmin4 4.6 Build for Windows, Once MAC Build will available, will test it accordingly. Kind Regards, On Tue, Apr 30, 2019 at 12:22 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.6 candidate builds and source can be found at > https://developer.pgadmin.org/bu

Re: Minor patch to fix reggression of select2 option

2019-04-30 Thread Dave Page
Hi What's the RM for this? On Tue, Apr 30, 2019 at 8:00 AM Neel Patel wrote: > Hi Team, > > Please find attached patch to fix the issue where we should properly > assigned 'dropdownParent' select2 options. > > This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717 > > Do review

Re: pgAdmin4 v4.6 candidate builds

2019-04-30 Thread Akshay Joshi
Hi Fahar/Hackers New builds are available at https://developer.pgadmin .org/builds/2019-04-30-2/ Please verify it for release on Thursday. On Tue, Apr 30, 2019 at 1:00 PM Fahar Abbas wrote: > Hi Akshay! > > Thanks for sharing pgAdmin4 4.6 Build for Windows, Once MAC Build will > available, will

Re: Minor patch to fix reggression of select2 option

2019-04-30 Thread Neel Patel
Hi Dave, RM is 4218 Thanks, Neel Patel On Tue, Apr 30, 2019 at 1:25 PM Dave Page wrote: > Hi > > What's the RM for this? > > On Tue, Apr 30, 2019 at 8:00 AM Neel Patel > wrote: > >> Hi Team, >> >> Please find attached patch to fix the issue where w

[pgAdmin][RM4219] Fix 404 flask error for popper.js

2019-04-30 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch for 404 flask error for popper.js. Kindly review. Regards, Ganesh Jaybhay RM4219.patch Description: Binary data

pgAdmin 4 commit: Properly assign dropdownParent in Select2 controls. F

2019-04-30 Thread Dave Page
Properly assign dropdownParent in Select2 controls. Fixes #4218 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=34b59da526415e3f383a72d9f6c0233aaa406317 Author: Neel Patel Modified Files -- docs/en_US/release_notes.rst

Re: Minor patch to fix reggression of select2 option

2019-04-30 Thread Dave Page
Thanks, applied. Note to Akshay: When you tag 4.6, please make sure it is on the correct commit, and if we need to rewrap, you may need to move this issue to the 4.6 release notes. Thanks! On Tue, Apr 30, 2019 at 9:22 AM Neel Patel wrote: > Hi Dave, > > RM is 4218

pgAdmin 4 commit: Ensure popper.js is installed when needed. Fixes #421

2019-04-30 Thread Dave Page
Ensure popper.js is installed when needed. Fixes #4219 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f02f91cbf16f50259e63820211f3b2a13e5a4c73 Modified Files -- docs/en_US/release_notes_4_7.rst | 1 + web/webpack.config.js

Re: [pgAdmin][RM4219] Fix 404 flask error for popper.js

2019-04-30 Thread Dave Page
Thanks, patch applied. On Tue, Apr 30, 2019 at 11:18 AM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for 404 flask error for popper.js. > > Kindly review. > > Regards, > Ganesh Jaybhay > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: