pgAdmin 4 commit: Fixed 'Location cannot be empty' error when open Tabl

2019-04-18 Thread Akshay Joshi
Fixed 'Location cannot be empty' error when open Tablespace properties. Fixes #4134 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d96f453e7f708f0254ddf9462b7bd651b4a8a3c1 Author: Aditya Toshniwal Modified Files -- docs/en_US/re

Re: [pgAdmin][RM4134] Tablespace location shows error "Location cannot be empty" in the pgAdmin 4

2019-04-18 Thread Akshay Joshi
Thanks patch applied. On Thu, Apr 18, 2019 at 11:10 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix the error "Location cannot be empty" in > Tablespace dialog, which occurs even if Location is disabled in edit mode. > > -- > Thank

pgAdmin 4 commit: Skip the permissions test on Windows which doesn't su

2019-04-18 Thread Dave Page
Skip the permissions test on Windows which doesn't support Unix style file permissions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ef71cf7495c6724bf27ff24bab35aa34678fe3d Modified Files -- web/pgadmin/setup/tests/test_permis

pgAdmin 4 commit: Urgh. Typo.

2019-04-18 Thread Dave Page
Urgh. Typo. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ac064de42e80cc8313900eab51567011c9cb0b0 Modified Files -- web/pgadmin/setup/tests/test_permissions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Ensure that confirmation dialog should be popped up b

2019-04-18 Thread Akshay Joshi
Ensure that confirmation dialog should be popped up before reload of query tool or debugger if it is opened in a new browser tab. Fixes #4101 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49b318c39e932b81472f2b186c3d242fedd41f2d Author: Adit

Re: [pgAdmin][RM4101] No confirmation before window refresh in query tabs

2019-04-18 Thread Akshay Joshi
Thanks patch applied. On Wed, Apr 17, 2019 at 3:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to ask for confirmation before reload if query tool > or debugger is opened in a new tab. > I have also fixed a small issue where debugger is

pgAdmin 4 commit: Fix skip on Windows.

2019-04-18 Thread Dave Page
Fix skip on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94e1820ccdd23daa88aaf8782d2013af4d354ef4 Modified Files -- web/pgadmin/setup/tests/test_permissions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pgAdmin4][Patch] - RM 4160 - (Re-)Edit column properties blocked to "Increment value cannot be empty" error.

2019-04-18 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4160 - (Re-)Edit column properties blocked to "Increment value cannot be empty" error. Thanks, Khushboo RM_4160.patch Description: Binary data