Re: pgAdmin4 v4.4 candidate builds

2019-04-04 Thread Fahar Abbas
Hi Akshay, One Round of testing has been completed for pgAdmin4 4.4 and it's ready for the Release. Kind regards, On Mon, Apr 1, 2019 at 4:36 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.4 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-04-01-1/ > >

pgAdmin 4 v4.4 released

2019-04-04 Thread Akshay Joshi
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.4. This release of pgAdmin 4 includes over 35 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_4.html. pgAdmin is the leading Open So

[pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-04 Thread Khushboo Vashi
Hi, Please find the attached patch to fix: 1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable 2. #2392 - Datagrid: If we delete any row it also saves newly added row Thanks, Khushboo RM_3605_2392.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 4104 & RM 3938 - Partition table fixes

2019-04-04 Thread Akshay Joshi
Hi Khushboo Below are the review comments: - Can you please add the help message for 'Default' in note control as we do have for 'From/To' control. Also strings are not properly aligned in the note control for Partition Keys and Partitions. - Update the documentation and screenshot wi

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-04 Thread Akshay Joshi
Hi Khushboo #3605 is fixed and found below issue in #2392 - As per steps given in RM, I have perform the same. But when I delete the row, delete button is still enabled and save button is disabled even though newly created row is still there. Apart from that code looks good to me. Ple

[pgAdmin4][RM#4142] Add the recommended ESLinter checks again.

2019-04-04 Thread Murtuza Zabuawala
Hi, Issue: We removed recommended ESLinter checking with RM#4019 commit. If you see now ESLint is no longer complaining about many issues which are listed here https://eslint.org/docs/rules/ and marked as [✓]. Simple test case is to add debugger; statement in JS code and run linter, we can see th

pgAdmin 4 commit: Fixed feature test issues

2019-04-04 Thread Akshay Joshi
Fixed feature test issues Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c4c09f237ecde2fdd593326d8c70c4e49aa35b6 Author: Usman Muzaffar Modified Files -- .../feature_tests/xss_checks_roles_control_test.py| 15 ++-