Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

Hi Dave, Please find the attached updated patch. Thanks, Khushboo On Thu, Mar 21, 2019 at 3:57 PM Dave Page wrote: > Hi > > On Thu, Mar 21, 2019 at 9:52 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Mar 20, 2019 at 8:37 PM Dave Page wrote: >> >>> Hi

Re: [pgAdmin4][RM4105] select for json context doesn't work

Thanks, patch applied (but not yet pushed for network reasons. Sigh). On Wed, Mar 27, 2019 at 3:02 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue, where selecting json type was not > rendering the grid. > This also fixes RM

pgAdmin 4 commit: Fix an issue where JSON data would not be rendered in

Fix an issue where JSON data would not be rendered in the Query Tool. Fixes #4105 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbc6aea497c81b314e5744a24c643f369538a53d Author: Aditya Toshniwal Modified Files -- docs/en_US/rele

pgAdmin 4 commit: Include inherited column comments and defaults in rev

Include inherited column comments and defaults in reverse engineered table SQL. Fixes #2627 Include comment SQL for inherited columns in reverse engineered table SQL. Fixes #4037 Include inherited columns in SELECT scripts. Fixes #4058 Branch -- master Details --- https://git.postgresql

[pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."

Hi Hackers, I have started working on RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View." and while working I have figured out following issues: - Reset some/all the parameter for table and toast table is not implemented. - Value of "Custom auto-vacuum?

[pgAdmin4][Patch] - RM 4082 - Download CSV error displayed for procedure and functions with create script

Hi, Please find the attached patch to fix the RM #4082 - Download CSV error displayed for procedure and functions with create script. The error message in case of any error while downloading the CSV file was blank, so now it has been displayed. Thanks, Khushboo diff --git a/web/pgadmin/tools/sql

Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table

Thanks, applied. On Thu, Mar 28, 2019 at 2:00 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Just to mention, the patch also fixes RM2627, RM4058. > > On Wed, Mar 27, 2019 at 6:25 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers,

pgAdmin 4 commit: Add support for IDENTITY columns. Fixes #4030

Add support for IDENTITY columns. Fixes #4030 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=97919d091a64afcd3f168c4ebaad04fce442b8a7 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_4.rst |

Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

Thanks, patch applied! One thing I did notice - Sequences are missing the system object property. I've re-opened #1257 On Thu, Mar 28, 2019 at 5:17 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Thu

pgAdmin 4 commit: PEP-8 fixes.

PEP-8 fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d45a3cb24e1c4f185d83eb85adf2dd9a0489c63 Modified Files -- .../databases/schemas/sequences/__init__.py| 6 +++-- .../tables/columns/tests/test_column_add.py

[pgAdmin4][RM4085] CSV download should show error messages in messages tab and not in the CSV file

Hi Hackers, Attached is the patch to handle Postgres or other errors gracefully when clicked on download CSV. PostgresSQL errors will be shown in messages tab similar to normal SQL execute. The patch also covers RM4082 (a patch is available for this on hackers, but this is an improved version :P.

[pgAdmin4][Patch] - Minor patch to remove javascript debugger

Hi, Please find the attached patch to remove the javascript debugger from the code. Thanks, Khushboo remove_debugger.patch Description: Binary data