pgAdmin 4 commit: Update wcDocker to fix the issue where the Scratch Pa

2019-03-21 Thread Dave Page
Update wcDocker to fix the issue where the Scratch Pad grows in size if the results panel is resized. Fixes #3968 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=61f11aa4fcbf223c00ddab5fcf03d8808ef2bef3 Author: Aditya Toshniwal Modified File

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

2019-03-21 Thread Dave Page
Thanks, applied. Do we still need our fork of wcDocker? Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP. Thanks! On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal < aditya.toshni...

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

2019-03-21 Thread Aditya Toshniwal
Hi, On Thu, Mar 21, 2019 at 2:51 PM Dave Page wrote: > Thanks, applied. > > Do we still need our fork of wcDocker? > Yes we do. pgAdmin depends on changes done on forked wcDocker. > > Also, please let me know when you're running low on things to do in this > sprint (not including schema diff).

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

2019-03-21 Thread Dave Page
On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Mar 21, 2019 at 2:51 PM Dave Page wrote: > >> Thanks, applied. >> >> Do we still need our fork of wcDocker? >> > Yes we do. pgAdmin depends on changes done on forked wcDocker. > >> >> Al

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

2019-03-21 Thread Aditya Toshniwal
Hi, On Thu, Mar 21, 2019 at 3:08 PM Dave Page wrote: > > > On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, Mar 21, 2019 at 2:51 PM Dave Page wrote: >> >>> Thanks, applied. >>> >>> Do we still need our fork of wcDocker? >>> >>

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

2019-03-21 Thread Dave Page
On Thu, Mar 21, 2019 at 9:41 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Mar 21, 2019 at 3:08 PM Dave Page wrote: > >> >> >> On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, Mar 21, 201

Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

2019-03-21 Thread Khushboo Vashi
Hi Dave, On Wed, Mar 20, 2019 at 8:37 PM Dave Page wrote: > Hi > > On Wed, Mar 20, 2019 at 7:30 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM #4030 - IDENTITY column not >> recognised. >> - Added support for IDENTITY col

Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

2019-03-21 Thread Dave Page
Hi On Thu, Mar 21, 2019 at 9:52 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Mar 20, 2019 at 8:37 PM Dave Page wrote: > >> Hi >> >> On Wed, Mar 20, 2019 at 7:30 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the

Re: Regarding DDL in pgadmin

2019-03-21 Thread Dave Page
[please keep messages on-list] On Thu, Mar 21, 2019 at 10:16 AM Travis wrote: > Thanks a lot! > > yeah rev eng sucks. > > I'm currently going through the source code, can you kindly point me to > the module where the rev engineering is already being done.? > Most of the heavy lifting will be do

[pgAdmin] - RM-3936 -Feature tests patch

2019-03-21 Thread Usman Muzaffar
Hi Hackers, Please find here attached patch for feature tests. Due to intermittent failures on jenkins and some other system, following fixes are done(but not limited to them only as other small fixes are also done) - tree toggle issue - Query tool inteliSence issue eg. when there is only o

pgAdmin 4 commit: Tidy up table formatting in the docs. Thanks to Susan

2019-03-21 Thread Dave Page
Tidy up table formatting in the docs. Thanks to Susan Douglas for the tips! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f22503ad2f6797d4c967ea749ee2cbe74d1880f Modified Files -- docs/en_US/desktop_deployment.rst | 26 +---

pgAdmin 4 commit: Many fixes to the stability of the feature tests, inc

2019-03-21 Thread Dave Page
Many fixes to the stability of the feature tests, including: tree toggle issue Query tool inteliSence issue eg. when there is only one option and drop down is not shown Backup and restore windows locator changes Fixes required due to resolving rm # 4041 Dependent tab not showing data sometime, so

Re: [pgAdmin] - RM-3936 -Feature tests patch

2019-03-21 Thread Dave Page
Hi Awesome job (and they're much faster now!) - patch committed (but there's still work to do :-( ). Here are my thoughts: - The first time I ran the tests, a couple failed. This was because the external process output dialogue was too big for the screen (when I ran on a large screen and maximise

pgAdmin 4 commit: Add new file missed in last commit.

2019-03-21 Thread Dave Page
Add new file missed in last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33693734fc99806f047bdff08bfae070ce9f93ff Author: Usman Muzaffar Modified Files -- web/pgadmin/feature_tests/locators.py | 22 +

pgAdmin 4 commit: Fix PEP-8 issues.

2019-03-21 Thread Dave Page
Fix PEP-8 issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2b5629a012a278437232f231bf31ae39cc24235 Modified Files -- .../feature_tests/pg_utilities_backup_restore_test.py | 3 --- .../feature_tests/query_tool_auto_comp

pgAdmin 4 commit: Don't use old-style variable notation.

2019-03-21 Thread Dave Page
Don't use old-style variable notation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17464aa0343383afd22d2006e69172f17001c3b0 Modified Files -- pkg/docker/build.sh | 20 +++--- pkg/mac/build.sh| 160 ++

pgAdmin 4 commit: Fix indent.

2019-03-21 Thread Dave Page
Fix indent. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=89784413dd375b98e4816952786430804d5bfb6c Modified Files -- docs/en_US/pgagent_install.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Improve the German translation for Backup Server, per

2019-03-21 Thread Dave Page
Improve the German translation for Backup Server, per H Re. Fixes #4090 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83bb07e01dd403fedd40c2fbfbc6254cbacd930e Modified Files -- docs/en_US/release_notes_4_4.rst |

RM3887 - User storage home folder collision

2019-03-21 Thread Dave Page
Here's a patch to fix and repair $SUBJECT. Anyone see any issues with it? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3887.diff Description: Binary data

Re: RM3887 - User storage home folder collision

2019-03-21 Thread Khushboo Vashi
Hi Dave, On Thu, Mar 21, 2019 at 10:41 PM Dave Page wrote: > Here's a patch to fix and repair $SUBJECT. > > Anyone see any issues with it? > > Looks good to me. Thanks, Khushboo > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprise

Re: RM3887 - User storage home folder collision

2019-03-21 Thread Aditya Toshniwal
Looks good to me. On Thu, Mar 21, 2019 at 10:41 PM Dave Page wrote: > Here's a patch to fix and repair $SUBJECT. > > Anyone see any issues with it? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise Postgre