[pgAdmin4][RM4041] Graphical explain plan is not rendering for a query

Hi Hackers, This is a regression of json related commit. As json data is sent as text now, explain plan data (which is json data type) is not displaying. Attached patch will make the required changes in explain plan. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | Ent

[pgAdmin4][Patch]: RM #3659 Query tool does not give warning when Auto Commit is turned on in an incomplete transaction

Hi Hackers, Attached is the patch to fix RM #3659 "Query tool does not give warning when Auto Commit is turned on in an incomplete transaction". Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3659.patch Description: Binary

Re: [RM#3998] Custom encode forward slashes in the grid title

Hi Murtuza, Will this work if server name contains - !PG! ? On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > PFA patch for the issue RM#3998. If the URL contains the forward slash > value in the query tool title and if pgAdmin4 is behind

Re: [RM#3998] Custom encode forward slashes in the grid title

On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Murtuza, > > Will this work if server name contains - !PG! ? > No, it won't and it's a custom signature we can finalize it whatever team thinks will work if the functionality is working properly. >

Re: [RM#3998] Custom encode forward slashes in the grid title

Hi Murtuza, I would suggest adding a new url param like "?fslash=12,15", which says where to put the forward slashes. So if server name is "PostgreSQL/11" - connecting to postgres database with postgres username: Old URL: http://localhost:5005/datagrid/panel/3400871/true/postgres%2Fpostgres%40Pos

Re: [RM#3998] Custom encode forward slashes in the grid title

That's a good idea. Seems much more robust. On Fri, Mar 1, 2019 at 11:02 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Murtuza, > > I would suggest adding a new url param like "?fslash=12,15", which says > where to put the forward slashes. > > So if server name is "PostgreS

pgAdmin 4 commit: Set the Gunicorn worker timeout to match the configur

Set the Gunicorn worker timeout to match the configured session expiry. Partially fixes #3656 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f552519ed6c5b3d005a7fe849322f47010342127 Modified Files -- pkg/docker/entrypoint.sh | 8

pgAdmin 4 commit: Optimise the Docker file to minimise the number of la

Optimise the Docker file to minimise the number of layers and maximise the chances that changes will be in the last layers built. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8f9e3e87be988c83f58b370e9cb7e31a1163860 Modified Files

pgAdmin 4 commit: Fix graphical explain now that JSON data is sent as t

Fix graphical explain now that JSON data is sent as text to stop JS futzing with it. Fixes #4041 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74cfeabd02c8fd63d2604ac826dae7ed4308a91e Author: Aditya Toshniwal Modified Files --

Re: [pgAdmin4][RM4041] Graphical explain plan is not rendering for a query

Thanks, applied. On Fri, Mar 1, 2019 at 8:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > This is a regression of json related commit. As json data is sent as text > now, explain plan data (which is json data type) is not displaying. > Attached patch will make

Re: [RM#3998] Custom encode forward slashes in the grid title

Hello Aditya, Yes, that is a better approach, PFA updated patch. Thanks, Murtuza On Fri, Mar 1, 2019 at 4:35 PM Dave Page wrote: > That's a good idea. Seems much more robust. > > On Fri, Mar 1, 2019 at 11:02 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Murtuza, >>

pgAdmin 4 commit: Fix resizing of the results grid, when full of data.

Fix resizing of the results grid, when full of data. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6d295727c0277d841e170a38099182aa9102a3c Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/sqleditor/static/js/sqleditor

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

On Fri, Mar 1, 2019 at 5:39 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached fix. > > Thanks, > Khushboo > > > On Thu, Feb 28, 2019 at 6:58 PM Dave Page wrote: > >> Hi >> >> On Thu, Feb 28, 2019 at 3:46 AM Khushboo Vashi < >> khushboo.va...@enter

pgAdmin 4 commit: Fix download CSV for IE11 which doesn't support the d

Fix download CSV for IE11 which doesn't support the download attribute. Fixes #4040 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb747b803134cff6faa1115c1962100a2ce3bedb Author: Murtuza Zabuawala Modified Files -- web/pgadmin/

Re: [RM#4040] Fix Download CSV option on IE11

Thanks, applied. On Fri, Mar 1, 2019 at 6:49 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > We have used download attribute to download CSV file from query tool but > IE11 does not support download attribute, we will use msSaveBlob() instead > for IE11. > > > -- > Reg

pgAdmin 4 commit: Add full support and testsfor all PG server side enco

Add full support and testsfor all PG server side encodings. Fixes #3992. Fixes #3982. Fixes #3911 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=849e34c2f763a9d084bd21840df6dde60c0a1b06 Author: Khushboo Vashi Modified Files -- .

pgAdmin 4 commit: Update release notes.

Update release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a Modified Files -- docs/en_US/release_notes_4_3.rst | 3 +++ 1 file changed, 3 insertions(+)

Re: [pgAdmin4][Patch] - Encoding Fixes

Thanks, applied. On Fri, Mar 1, 2019 at 7:06 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to support all the supported encodings by > PostgreSQL. > > Thanks, > Khushboo > > On Thu, Feb 28, 2019 at 10:53 AM Khushboo Vashi < > khushboo.va...@e

Build failed in Jenkins: pgadmin4-master-python34 #959

See Changes: [Dave Page] Fix download CSV for IE11 which doesn't support the download attribute. [Dave Page] Add full support and testsfor all PG server side encodings. Fixes #3992. [Dave Page] Updat

Build failed in Jenkins: pgadmin4-master-python36 #958

See Changes: [Dave Page] Fix download CSV for IE11 which doesn't support the download attribute. [Dave Page] Add full support and testsfor all PG server side encodings. Fixes #3992. [Dave Page] Updat

pgAdmin 4 commit: Fix PEP-8 issue.

Fix PEP-8 issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecbba79c2a11d5d367b9c1b3fb5b2bd1b7573ef4 Modified Files -- web/pgadmin/utils/tests/test_encoding.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Build failed in Jenkins: pgadmin4-master-python27 #969

See Changes: [Dave Page] Add full support and testsfor all PG server side encodings. Fixes #3992. [Dave Page] Update release notes. -- [...truncated 272 B...] C

Build failed in Jenkins: pgadmin4-master-python35 #950

See Changes: [Dave Page] Add full support and testsfor all PG server side encodings. Fixes #3992. [Dave Page] Update release notes. -- Started by an SCM change

Build failed in Jenkins: pgadmin4-master-python37 #197

See Changes: [Dave Page] Fix download CSV for IE11 which doesn't support the download attribute. [Dave Page] Add full support and testsfor all PG server side encodings. Fixes #3992. [Dave Page] Updat

Jenkins build is back to normal : pgadmin4-master-python27 #970

See

Jenkins build is back to normal : pgadmin4-master-python35 #951

See

pgAdmin 4 commit: Custom-encode forward slashes in URL parameters as Ap

Custom-encode forward slashes in URL parameters as Apache HTTPD doesn't allow them in some cases. Fixes #3998 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36ffdb93e83e0f83abd760e004fa867795762bf8 Author: Murtuza Zabuawala Modified Files -

Re: [RM#3998] Custom encode forward slashes in the grid title

Thanks, applied. On Fri, Mar 1, 2019 at 12:41 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello Aditya, > > Yes, that is a better approach, PFA updated patch. > > Thanks, > Murtuza > > > On Fri, Mar 1, 2019 at 4:35 PM Dave Page wrote: > >> That's a good idea. Seems much m

Jenkins build is back to normal : pgadmin4-master-python37 #198

See

Re: [pgAdmin4][Patch]: RM #3659 Query tool does not give warning when Auto Commit is turned on in an incomplete transaction

Hi On Fri, Mar 1, 2019 at 9:07 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3659 "Query tool does not give warning > when Auto Commit is turned on in an incomplete transaction". > > Please review it. > The behaviour doesn't seem quite right here. I see two issues:

Jenkins build is back to normal : pgadmin4-master-python36 #959

See

Jenkins build is back to normal : pgadmin4-master-python34 #960

See

Re: [pgAdmin4][Patch] - Encoding Fixes

Hi Unfortunately this has introduced a regression: - Start pgAdmin from the command line or PyCharms. - Connect to a server, open a query tool and run a query (SELECT 1 will do). - Stop and restart the pgAdmin server. - Execute the query again in the client. The error "'Connection' object has no

Async queries pretending to be synchronous

In investigating #3656 I found the initial problem to be that when running in a container, Gunicorn will kill the worker process if a thread doesn't respond for 30 seconds by default. I fixed that by making the timeout match the application session timeout, but it revealed another issue. Given the

Interested in GSoC projects on pgAdmin 4

Dear PostgreSQL community: I am a MSc student in computer science working on data management research, and I will likely graduate this summer. I also was a participant of GSoC in 2017 working with the NRNB organization on data standards conversion. I have been a user of pgAdmin 4 briefly, and I a

Re: [pgAdmin4][Patch] - Encoding Fixes

Hi, Please find the attached patch for the regression fix. Thanks, Khushboo On Fri, Mar 1, 2019 at 9:41 PM Dave Page wrote: > Hi > > Unfortunately this has introduced a regression: > > - Start pgAdmin from the command line or PyCharms. > - Connect to a server, open a query tool and run a query

Re: [pgAdmin4][Patch]: RM #3659 Query tool does not give warning when Auto Commit is turned on in an incomplete transaction

Hi Dave On Fri, Mar 1, 2019 at 8:47 PM Dave Page wrote: > Hi > > On Fri, Mar 1, 2019 at 9:07 AM Akshay Joshi > wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3659 "Query tool does not give warning >> when Auto Commit is turned on in an incomplete transaction". >> >> Please revie