[pgAdmin4][Patch]: Backform Switch control clean-up

2019-02-05 Thread Khushboo Vashi
Hi, Please find the attached patch for cleaning up the unwanted extended versions of Backform Switch controls. The Bootstrap Switch Control was extended only for alignment at most of the places. In this patch, I have introduced a configurable option to set the necessary class on the main div and a

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-02-05 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch to fix possible causes of failure. Kindly review (fingers crossed) On Tue, Feb 5, 2019 at 10:48 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >>

Re: Packagers: Handling upgrade checks

2019-02-05 Thread Sandeep Thakkar
Hi Dave, On Wed, Jan 2, 2019 at 6:44 PM Dave Page wrote: > Packagers, > > As you probably know, pgAdmin 4 checks for updates upon startup, and > if a newer version is available, directs the user to www.pgadmin.org > to download it. > > The is a problem if your pgAdmin came with a PostgreSQL ins

Re: Packagers: Handling upgrade checks

2019-02-05 Thread Dave Page
Hi On Tue, Feb 5, 2019 at 12:27 PM Sandeep Thakkar wrote: > > Hi Dave, > > > On Wed, Jan 2, 2019 at 6:44 PM Dave Page wrote: >> >> Packagers, >> >> As you probably know, pgAdmin 4 checks for updates upon startup, and >> if a newer version is available, directs the user to www.pgadmin.org >> to d

pgAdmin 4 commit: Update Japanese translation.

2019-02-05 Thread Dave Page
Update Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6ba8899d18eed1b6a66f674f5d66f9eab494e7e Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 162322 -

Re: Japanese translation for v4.2

2019-02-05 Thread Dave Page
Thanks, patch applied. On Mon, Feb 4, 2019 at 2:46 PM fn ln wrote: > > Hello. > Updated Japanese translation for upcoming version 4.2 is in attachment. > Message catalog is based on git bb25d1a9. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.ent

pgAdmin 4 commit: Update French translation.

2019-02-05 Thread Dave Page
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3fae181c27f45c457388159923cfd34b31b01da6 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 155956 -> 15619

Re: french translation update

2019-02-05 Thread Dave Page
Thanks - patch applied. On Mon, Feb 4, 2019 at 4:34 PM wrote: > > hello > here is the french translation update for upcoming version > fred > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Backform Switch control clean-up

2019-02-05 Thread Dave Page
Thanks, patch applied. On Tue, Feb 5, 2019 at 9:13 AM Khushboo Vashi wrote: > > Hi, > > Please find the attached patch for cleaning up the unwanted extended versions > of Backform Switch controls. > The Bootstrap Switch Control was extended only for alignment at most of the > places. In this pa

pgAdmin 4 commit: Clean up the unwanted extended versions of Backform S

2019-02-05 Thread Dave Page
Clean up the unwanted extended versions of Backform Switch controls. The Bootstrap Switch Control was extended only for alignment in most places. IIntroduce a configurable option to set the necessary class on the main div and also remove the extra extended controls. Branch -- master Details -

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-02-05 Thread Akshay Joshi
Hi Aditya Some improvement, 1 test case is still failing but not consistent. I have run the test cases 3 times out of which one time all runs successfully. On Tue, Feb 5, 2019 at 5:28 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch

[pgAdmin4][Patch]: RM #3942 Close all the connections gracefully when logout from pgAdmin4

2019-02-05 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3942 "Close all the connections gracefully when logout from pgAdmin4". Initial patch sent by Harshal that contains the logic of registration/callback mechanism when user logout from pgAdmin4. Please review it. -- *Akshay Joshi* *Sr. Software Archit