[pgAdmin4][RM3903] Query Tool Initialization Error

2019-01-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix "Query Tool Initialization Error" which occurs on opening query tool for some users. The problem was, request data was sent from client but was not read by back end service. In flask, if you receive POST data in a request you *must* read it before returning

Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-28 Thread Murtuza Zabuawala
Hi, PFA minor patch, To display an error on UI when there is a backend error for the grant wizard request. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi wrote: > Thanks pa

Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-28 Thread Akshay Joshi
Hi Murtuza Here are my review comments: - Exact error should be logged in the log file and on GUI we should show message like "Unable to fetch object". - Message should be shown in the status bar. - If there is an error to fetch one kind of object, we should show other objects.

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-01-28 Thread Dave Page
Hi On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the patch to fix failing SQL editor related feature tests. > The failure is occurring mostly because of send_keys function of selenium > which sometimes does not input the complete text. The change will us

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-01-28 Thread Aditya Toshniwal
Hi Dave, On Mon, Jan 28, 2019 at 5:01 PM Dave Page wrote: > Hi > > On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal > wrote: > > > > Hi Hackers, > > > > Attached is the patch to fix failing SQL editor related feature tests. > > The failure is occurring mostly because of send_keys function of >

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-01-28 Thread Dave Page
On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal wrote: > > Hi Dave, > > On Mon, Jan 28, 2019 at 5:01 PM Dave Page wrote: >> >> Hi >> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal >> wrote: >> > >> > Hi Hackers, >> > >> > Attached is the patch to fix failing SQL editor related feature tes

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-01-28 Thread Aditya Toshniwal
On Mon, Jan 28, 2019 at 5:39 PM Dave Page wrote: > On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal > wrote: > > > > Hi Dave, > > > > On Mon, Jan 28, 2019 at 5:01 PM Dave Page wrote: > >> > >> Hi > >> > >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal > >> wrote: > >> > > >> > Hi Hackers,

[pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package

2019-01-28 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM 3927 "Unable to debug the procedure inside package". Problem with the existing code is we assume that "PLDBGBREAK" will be always found in the first element of the notification list. In this patch we loop through the list and found the string. Apart fro

pgAdmin 4 commit: Fixed Query Tool Initialization Error. Fixes #3903

2019-01-28 Thread Akshay Joshi
Fixed Query Tool Initialization Error. Fixes #3903 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=821496dc84b44e1508ec9a588a229d407e9e073a Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.rst

Re: [pgAdmin4][RM3903] Query Tool Initialization Error

2019-01-28 Thread Akshay Joshi
Thanks patch applied. On Mon, Jan 28, 2019 at 2:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix "Query Tool Initialization Error" which > occurs on opening query tool for some users. > The problem was, request data was sent from cl