Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-20 Thread Akshay Joshi
Hi Hackers, Attached is the modified patch with regression tests. On Wed, Sep 19, 2018 at 11:32 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Fri, Sep 14, 2018 at 8:02 PM, Dave Page wrote: > >> Hi >> >> On Fri, Sep 14, 2018 at 12:48 PM, Akshay Joshi < >> akshay.jo...

Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-20 Thread Harshal Dhumal
Hi Akshay, We can do one minor improvement for python 2. Instead of below check *if type(val) in (str, unicode) :* we can check val against *basestring * Thanks, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://w

Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-20 Thread Akshay Joshi
On Thu, Sep 20, 2018 at 8:38 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Akshay, > > We can do one minor improvement for python 2. Instead of below check > *if type(val) in (str, unicode) :* > we can check val against *basestring >

Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-20 Thread Murtuza Zabuawala
Instead, we can utilize in-built 'six' module which will work in both Py 2.x & 3.x >>> isinstance(val, string_types) -- Murtuza On Thu, Sep 20, 2018 at 8:38 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Akshay, > > We can do one