Re: PGAgent 4.0 error feedback

2018-06-11 Thread Rob Emery
Hi Ashesh, Log-level wise I was using the same command for both versions: ./pgagent -f -l 2 -t 1 -r 1 'hostaddr=server user=username password=password dbname=postgres' and messing up the connection string in various ways (missing dbname, incorrect password, incorrect hostaddr) This was built a

Re: PGAgent 4.0 error feedback

2018-06-11 Thread Ashesh Vashi
Hi Rob, On Mon, Jun 11, 2018 at 12:50 PM, Rob Emery wrote: > Hi Ashesh, > > Log-level wise I was using the same command for both versions: > > ./pgagent -f -l 2 -t 1 -r 1 'hostaddr=server user=username > password=password dbname=postgres' > > and messing up the connection string in various way

Fwd: PGAgent 4.0 error feedback

2018-06-11 Thread Rob Emery
Hello Again, I've just tested the patch and the output is *much* more verbose with the same set of flags now, even more so than the old version (see attached). Thanks, Rob On 11/06/2018, Ashesh Vashi wrote: > Hi Rob, > > > On Mon, Jun 11, 2018 at 12:50 PM, Rob Emery > wrote: > >> Hi Ashesh, >>

Re: PGAgent 4.0 error feedback

2018-06-11 Thread Robert Emery
Hello Again, I've just tested the patch and the output is *much* more verbose with the same set of flags now, even more so than the old version (see attached). Thanks, Rob On 11/06/2018, Ashesh Vashi wrote: > Hi Rob, > > > On Mon, Jun 11, 2018 at 12:50 PM, Rob Emery > wrote: > >> Hi Ashesh, >>

Re: PGAgent 4.0 error feedback

2018-06-11 Thread Ashesh Vashi
On Mon, Jun 11, 2018 at 1:38 PM, Robert Emery wrote: > Hello Again, > > I've just tested the patch and the output is *much* more verbose with the > same > set of flags now, even more so than the old version (see attached). > Yes. A many systems, pgAgent service starts before the database service

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-11 Thread Ashesh Vashi
Hi Team, On Sat, May 5, 2018 at 3:31 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > *...* > 3. Start the discussion on application architecture > > Why should we care about location of files inside a our application? > > Why is this way better the another? > > These are 2 go

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-06-11 Thread Ashesh Vashi
On Mon, Jun 11, 2018 at 3:59 PM, Ashesh Vashi wrote: > Hi Team, > > On Sat, May 5, 2018 at 3:31 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> *...* >> 3. Start the discussion on application architecture >> >> Why should we care about location of files inside a our appl

RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-11 Thread Aditya Toshniwal
Hi Hackers, This is regarding RM3294 which I am working on, where user needs to reset the layout to see the changed preferences parameters. I am able to implement it, and have used the following approach: 1) when preference changed, fire a custom event - prefChangedEvent 2) listent to prefChangedE

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-11 Thread Harshal Dhumal
On Mon, Jun 11, 2018 at 6:02 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > This is regarding RM3294 which I am working on, where user needs to reset > the layout to see the changed preferences parameters. I am able to > implement it, and have used the following

Re: [pgadmin4][patch] Use pytest test runner for unit tests

2018-06-11 Thread Dave Page
Hi On Mon, Jun 4, 2018 at 3:26 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Known issues: >>> >>>- Python 2.7, the library we are using for assertions (Grappa) is >>>failing while trying to assert on strings. We created a PR to the >>> library: >>>https://gith

Re: [pgadmin][patch] Electron version 4.X

2018-06-11 Thread Dave Page
Hi On Fri, Jun 8, 2018 at 3:49 PM, Victoria Henry wrote: > > > On Tue, Jun 5, 2018 at 12:28 PM Dave Page wrote: > >> Hi >> >> On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> Attached you can find the patch that introd

pgAdmin 4 commit: Avoid an exception on GreenPlum when retrieving RE-SQ

2018-06-11 Thread Dave Page
Avoid an exception on GreenPlum when retrieving RE-SQL on a table. Fixes #3409 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=226c872a848c2fe16a1d7d57a1b4141f92493e22 Author: Victoria Henry Modified Files -- docs/en_US/release_no

Re: [pgAdmin][patch] RM3409 - Retrieving SQL from table throws exception

2018-06-11 Thread Dave Page
Thanks, patch applied. On Fri, Jun 8, 2018 at 7:43 PM, Victoria Henry wrote: > Hi hackers, > > Attached is a patch that fixes an exception when trying to view the SQL > tab on a GreenPlum database. > > Sincerely, > > Joao && Victoria > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter:

pgAdmin 4 commit: Fix labels and popups on EXPLAIN plan that were broke

2018-06-11 Thread Dave Page
Fix labels and popups on EXPLAIN plan that were broken by the jQuery 3 update. Fixes #3404 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2b0cf6727c991727799d2588d41366aaf58633a Author: Murtuza Zabuawala Modified Files -- web/p

Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node

2018-06-11 Thread Dave Page
Thanks, patch applied. On Sat, Jun 9, 2018 at 7:01 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Sorry, the previous patch had a typo, Here's an updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise Po

pgAgent commit: 1. Connection object was being accessed, which was alre

2018-06-11 Thread Dave Page
1. Connection object was being accessed, which was already released. 2. Changed the logic for checking the connection object existence. We're using "if (!ms_primaryCon)", which should convert the logic as boolean operator explicitly, which we defined for the 'DBconn' class. I suspect some compi

Re: [PATCH] pgAgent segfault

2018-06-11 Thread Dave Page
Thanks, patch applied. On Mon, Jun 11, 2018 at 5:25 AM, Ashesh Vashi wrote: > Hi Dave, > > While debugging the issue > > reported by Rob, I found one segfault. > Please find the attached

[pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

2018-06-11 Thread Joao De Almeida Pereira
Hi Hackers, Attached you can find the diff file that corrects RM 3415 ​ Thanks Joao RM_3415.diff Description: Binary data

Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

2018-06-11 Thread Ashesh Vashi
Hi Joao, On Tue, Jun 12, 2018 at 1:50 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find the diff file that corrects RM 3415 > > If I understand correctly, you're disabling the privileges for GPDB

Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

2018-06-11 Thread Robert Eckhardt
On Tue, Jun 12, 2018, 12:27 AM Ashesh Vashi wrote: > Hi Joao, > > On Tue, Jun 12, 2018 at 1:50 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> >> Attached you can find the diff file that corrects RM 3415 >> >> >

Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

2018-06-11 Thread Ashesh Vashi
On Tue, Jun 12, 2018 at 10:02 AM, Robert Eckhardt wrote: > > > On Tue, Jun 12, 2018, 12:27 AM Ashesh Vashi > wrote: > >> Hi Joao, >> >> On Tue, Jun 12, 2018 at 1:50 AM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> Attached you can find the diff fil

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-11 Thread Aditya Toshniwal
Hi Harshal, On Mon, Jun 11, 2018 at 6:37 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > On Mon, Jun 11, 2018 at 6:02 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> This is regarding RM3294 which I am working on, where user needs to reset >> the layout to see

pgAdmin 4 commit: Disable ACLs for the database objects for the Greenpl

2018-06-11 Thread Ashesh Vashi
Disable ACLs for the database objects for the Greenplum due to performance issue. Reviewed By: Ashesh Fixes #3415 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5048b4d0b8fd9b2b556e33231d2a77d4f7b01df Author: Joao De Almeida Pereira Modifi

Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

2018-06-11 Thread Ashesh Vashi
On Tue, Jun 12, 2018 at 10:04 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Tue, Jun 12, 2018 at 10:02 AM, Robert Eckhardt > wrote: > >> >> >> On Tue, Jun 12, 2018, 12:27 AM Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Joao, >>> >>> On Tue, Jun 12, 2018 at 1:5