Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node

Hi On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the regression issue introduced with RM#3271 commit > due to which label is not displaying under the graphical explain node, I've > attached the screenshot in RM for

Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11

Hi, Please ignore my previous patch, find the attached updated one. Thanks, Khushboo On Wed, Jun 6, 2018 at 12:12 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix #3362 - Fix the functions for PG > v11, and add support procedure for PG

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal wrote: > Hi Hackers, > > PFA updated patch as the previous one was not working as expected. I have > tried to make it similar to that of pgAdmin3 and you do not need to change > client_encoding as it is set now based on server encoding. It work

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote: > Hi > > On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch as the previous one was not working as expected. I have >> tried to make it similar to that

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Thu, Jun 7, 2018 at 12:05 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > > On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>>

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Aditya Sure. I did not find moving > web/pgadmin/tools/datagrid/static/js/datagrid.js. Please correct me if I am > missing anything. Generally speaking, I agree with moving/deleting files if it makes sense. But in regards to web/pgadmin/tools/datagrid/static/js/datagrid.js, it looks like this

[patch] Minor shutdown message grammar fix

Hi, dev team, I'm surfacing to offer this minor patch to update the shutdown messaging in the tray menu and various dialogs to use the two-word "shut down" when the message context is a verb rather than the one-word noun usage "shutdown". For context, see: * https://blogs.msdn.microsoft.com/oldn