pgAdmin 4 commit: Move the notifications tab between messages and histo

Move the notifications tab between messages and history as it seems more natural there. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=419f9069aee546fe818161cdd6f4bdab895dcaec Author: Akshay Joshi Modified Files -- web/pgadmin/t

Re: [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool

Thanks, applied. On Tue, Jun 5, 2018 at 1:28 PM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the minor patch to move 'Notifications' tab before "Query > History" in Query Tool. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Anthony/Victoria/Joao, I know I am very late to review on patch 004. The idea of moving js files from tools to static folder looks good, but I have a few suggestions: 1) Why don't we start using webpack alias's instead of using absolute path. For eg, import {RestoreDialogWrapper} from '../../.

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA updated patch as the previous one was not working as expected. I have tried to make it similar to that of pgAdmin3 and you do not need to change client_encoding as it is set now based on server encoding. It works fine with "view data" also. The only problem is, I cannot find equiva

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Aditya, 1) Why don't we start using webpack alias's instead of using absolute path. > For eg, > import {RestoreDialogWrapper} from > '../../../pgadmin/static/js/restore/restore_dialog_wrapper'; > can be used as import {RestoreDialogWrapper} from > 'pgadmin_static/js/restore/restore_dialog_wrapp

Re: [pgadmin][patch] Electron version 4.X

Hi Joao, Awesome job, I tried windows build & it is running very smooth on my Win10 VM, It took some time when I ran it for the first time (I think because it ran "update.exe") but it was quick when opened second time onwards (taking ~6-7 secs to display the main window). The main thing I notice

[pgAdmin4][RM#3404] Graphical explain plan do not display text under the node

Hi, PFA minor patch to fix the regression issue introduced with RM#3271 commit due to which label is not displaying under the graphical explain node, I've attached the screenshot in RM for your reference. RM_3404.diff Description: Binary data

Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node

Hi Murtuza, LGTM and passes tests: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/119 Sincerely, Victoria On Wed, Jun 6, 2018 at 1:04 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the regress

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Victoria, On Wed, Jun 6, 2018 at 8:55 PM, Victoria Henry wrote: > Hi Aditya, > > 1) Why don't we start using webpack alias's instead of using absolute >> path. For eg, >> import {RestoreDialogWrapper} from '../../../pgadmin/static/js/ >> restore/restore_dialog_wrapper'; >> can be used as impo

Re: pgAgent 4.0 patch

Hello Fahar, File, pgagent-4.0.0-1-linux-x64.run is uploaded @ https://uploads.enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6 On Tue, Jun 5, 2018 at 3:10 PM, Dave Page wrote: > Thanks, committed with those changes. > > Paresh; can you please create some pgAgent 4.0 installe

Re: pgAgent 4.0 patch

Hi Paresh, Thanks for sharing pgagent linux64 installers. On Thu, Jun 7, 2018 at 11:39 AM, Paresh More wrote: > Hello Fahar, > > File, pgagent-4.0.0-1-linux-x64.run is uploaded @ https://uploads. > enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6 > > On Tue, Jun 5, 2018 at 3