pgAdmin 4 commit: Use test methods with @patch rather than directly.

Use test methods with @patch rather than directly. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83477224cb52415859f387cc6f8738c880bdbd9b Author: Joao Pedro De Almeida Pereira Modified Files -- .../utils/tests/test_start_running

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

On Thu, Mar 8, 2018 at 2:22 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > Completely forgot about this python "feature"... > Attached is the fix. > Thanks, applied. > > Just as a side question, does anyone else feel the pain of wanting to run > a sin

pgAdmin 4 commit: Fix SQL generated when dropping NOT NULL from a "char

Fix SQL generated when dropping NOT NULL from a "char" column. Fixes #2989 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=985a004766e8ec8a99e843d28e86f0c89d06ea80 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Thanks, patch applied. On Thu, Mar 8, 2018 at 6:00 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thank you Joao > > Regards, > Murtuza > > > On Thu, Mar 8, 2018 at 10:19 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Murtuza/Dave, >> >> Nice

Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

Hi On Fri, Mar 9, 2018 at 3:54 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix below issues: > > 1. #2963 - Backup database, Restore database and Maintenance Database > failed for é object > 2. #3157 - Process viewer doesn't show comple

Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

Hi On Fri, Mar 9, 2018 at 3:32 PM, Dave Page wrote: > Hi > > On Fri, Mar 9, 2018 at 3:54 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix below issues: >> >> 1. #2963 - Backup database, Restore database and Maintenance Database >

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

Hello, Definitely running single tests is something that would be great, specially if you are TDDing something waiting 30-40 seconds to get feedback is a little cumbersome when the test you are concerned with take less then a second. In the process: 1. Write a test 2. Make the test pass 3. Refacto

Re: [pgAdmin4][RM#3140] Add service parameter

HI On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add service parameter in server dialog. > - Docs updated > - Test case added for Service ID parameter > > Please note, > I have extracted Connection class and Server manager c

Re: [pgAdmin4][RM#3140] Add service parameter

Hi Dave, I'll change the name and send you updated patch. On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: > HI > > On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to add service parameter in server dialog. >> - Docs updated >> - Test case

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

Hi On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > Definitely running single tests is something that would be great, > specially if you are TDDing something waiting 30-40 seconds to get feedback > is a little cumbersome when the test you a

Build failed in Jenkins: pgadmin4-master-python27-feature #14

See Changes: [Dave Page] Rewrite the runtime as a tray-based server which can launch a web [Dave Page] Bump the version to 3.0, per discussion on the mailing lists [Dave Page] Fix quoting of fun

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

On Fri, Mar 9, 2018 at 11:04 AM Dave Page wrote: > Hi > > On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello, >> Definitely running single tests is something that would be great, >> specially if you are TDDing something waiting 30-40 second

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

On Fri, Mar 9, 2018 at 4:29 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > > > On Fri, Mar 9, 2018 at 11:04 AM Dave Page wrote: > >> Hi >> >> On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello, >>> Definitely runnin

Re: ACI Tree

Hi Hackers, Maybe this list might not have a big group of users of the application itself, nevertheless it would be interesting to understand if this is a specific problem of GreenPlum Use Case or not. This issue is preventing a wider adoption of pgAdmin4 by the GreenPlum users. >From a preliminar

[pgadmin4][patch] Unit test fail on GreenPlum (#3190)

Hello Hackers, Attached you can find the patch that skip some tests and correct issues on SQL that are failing when trying to connect to a GreenPlum database. We did this by adding a attribute to to test_json called "db_type" that will carry the type of database we are running tests against. Whe

Re: ACI Tree

On Sat, Mar 10, 2018 at 2:04 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Maybe this list might not have a big group of users of the application > itself, nevertheless it would be interesting to understand if this is a > specific problem of GreenPlum Use Case