[pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hi, PFA patch to disable Gravatar image in Server mode. Requirments & Issues: - For security reasons. - For systems which do not have internet access. - Hangs pgAdmin4 while loading the page if connection has no internet access (as described in the ticket) -- Regards, Murtuza Zabuawala Enterpris

[pgAdmin4][RM#3175] Fix PEP-8 issues

Hi, PFA patch to fix PEP8 issues in Browser & Database modules, pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py pycodestyle --config=.pycodestyle pgadmin/browser/tests/ pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py pycodestyle --config=

[pgadmin4][patch] GreenPlum function statistics through an exception

Hi Hackers, You can find attached the resolution for issue 3176. When trying to retrieve the statistics from a function in a GreenPlum database an error is displayed, To fix this for version 5.X we decided to remove the ability to get statistics. Thanks Joao diff --git a/web/pgadmin/browser/server

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hello Khushboo, Looks like we are almost doen, just missing one PEP-8 issue: → pycodestyle --config=.pycodestyle pgadmin/tools pgadmin/tools/sqleditor/tests/test_poll_query_tool.py:46: [E126] continuation line over-indented for hanging indent 1 E126 continuation line over-indented for hanging

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hi Murtuza, Why are we doing this using templates? Can this be done with a request to the backend to get the image and then retrieve the Gravatar if it is defined or return a static image if not? + +{% if config.SERVER_MODE %} window.onload = function(e){ setTimeout(function() { - var gravat

Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

Hi Murtuza, Looks good, and all tests are green. I run the commands provided and nothing pops up. Only missing 374 :D Thanks Joao On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix PEP8 issues in Browser & Database modules,

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hi Joao, We are using Flask-Gravatar module for this and it is designed to work with template only. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Mar 5, 2018 at 8:57 PM, Joao De Almeid

Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

Thanks Joao for reviewing. On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > > Looks good, and all tests are green. I run the commands provided and > nothing pops up. > > Only missing 374 :D > ​:-) ​ > > Thanks > Joao > > On Mon, Mar

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hello, I understand that, but what do we win by using it? As you have noticed by now I am not very fond of using templates for everything, and I believe this is one of the things that we can skip templates. We might even shift this to a frontend concern and if we want there are node libraries to ge

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hi Joao, Your suggestion is good but in my own opinion it is overkill just to replace code {{ username| gravatar }} as rest of the syntax is pure HTML, This makes code much simpler and easy to understand. Apart from that we will be rendering 'index.html' template anyways and I don't see any extra

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

Hi Joao, I ran the testsuite in windows 10 with Python 3.4 and it fails for external tables. Linux it is working fine. Let me know if I miss anything. Please check the below logs. python runtests.py --pkg browser --exclude feature_tests